From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: linuxppc-dev@ozlabs•org,
Mariusz Kozlowski <m.kozlowski@tuxland•pl>,
paulus@samba•org, bwalle@suse•de, linux-kernel@vger•kernel.org
Subject: Re: 2.6.24-mm1: ppc32: too few arguments to function 'reserve_bootmem'
Date: Tue, 05 Feb 2008 16:00:08 +0300 [thread overview]
Message-ID: <47A85DD8.4080300@ru.mvista.com> (raw)
In-Reply-To: <20080204144036.cf22a402.akpm@linux-foundation.org>
Hello.
Andrew Morton wrote:
>> This is from ppc32:
>> CC arch/powerpc/mm/mem.o
>>arch/powerpc/mm/mem.c: In function 'do_init_bootmem':
>>arch/powerpc/mm/mem.c:256: error: too few arguments to function 'reserve_bootmem'
>>arch/powerpc/mm/mem.c:261: error: too few arguments to function 'reserve_bootmem'
>>Leftover from introduce-flags-for-reserve_bootmem.patch?
> Yes, I've had to fix that patch many times.
> --- a/arch/powerpc/mm/mem.c~introduce-flags-for-reserve_bootmem-powerpc-fix
> +++ a/arch/powerpc/mm/mem.c
> @@ -253,12 +253,13 @@ void __init do_init_bootmem(void)
> lmb_size_bytes(&lmb.reserved, i) - 1;
> if (addr < total_lowmem)
> reserve_bootmem(lmb.reserved.region[i].base,
> - lmb_size_bytes(&lmb.reserved, i));
> + lmb_size_bytes(&lmb.reserved, i),
> + BOOTMEM_DEFAULT);
> else if (lmb.reserved.region[i].base < total_lowmem) {
> unsigned long adjusted_size = total_lowmem -
> lmb.reserved.region[i].base;
> reserve_bootmem(lmb.reserved.region[i].base,
> - adjusted_size);
> + adjusted_size, BOOTMEM_DWEFAULT);
BOOTMEM_DWEFAULT, are you sure? :-)
WBR, Sergei
next prev parent reply other threads:[~2008-02-05 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080203171634.58ab668b.akpm@linux-foundation.org>
2008-02-04 20:29 ` 2.6.24-mm1: ppc32: too few arguments to function 'reserve_bootmem' Mariusz Kozlowski
2008-02-04 22:40 ` Andrew Morton
2008-02-05 13:00 ` Sergei Shtylyov [this message]
2008-02-05 13:25 ` Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A85DD8.4080300@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bwalle@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=m.kozlowski@tuxland$(echo .)pl \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox