Subject: Re: [Patch] 8xx: MGSUVD support

From: Heiko Schocher <[email-masked]>
Date: Mon, 10 Mar 2008 07:33:54 +0100

Hello Vitaly,

Vitaly Bordug wrote:
> Heiko Schocher wrote:
>> the following patch adds support for the MPC852 based mgsuvd board
>> from keymile.
> Looks good overall. Please add supported/working/not working etc SoC devices state along with the patch 
> description. Also a few really small comments below...

OK.

>> Signed-off-by: Heiko Schocher <[email-masked]>
>> ---
[...]
>> +
>> +		PowerPC,866@0 {
> But it's mpc852, isn't it?

Yes your are right.

>> +			device_type = "cpu";
>> +			reg = <0>;
>> +			d-cache-line-size = <d#16>;
>> +			i-cache-line-size = <d#16>;
>> +			d-cache-size = <d#8192>;
>> +			i-cache-size = <d#8192>;
>> +			timebase-frequency = <0>;  /* Filled in by
>> u-boot */
>> +			bus-frequency = <0>;  /* Filled in by u-boot
>> */
>> +			clock-frequency = <0>; /* Filled in by
>> u-boot */
>> +			interrupts = <f 2>;	// decrementer
>> interrupt
> I would like all the comments to be consistent C style (because that's it for the most other dts'es).

Okay, I fix this, and send a new patch.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany