Subject: Re: [Patch] 8xx: MGSUVD support

From: Heiko Schocher <[email-masked]>
Date: Mon, 10 Mar 2008 07:34:46 +0100

Hello Stephen,

Stephen Rothwell wrote:
> On Sun, 09 Mar 2008 10:56:29 +0100 Heiko Schocher <[email-masked]> wrote:
>> +++ b/arch/powerpc/platforms/8xx/mgsuvd.c
>>
>> +#include <asm/of_platform.h>
> 
> You should include linux/of_platform.h (not asm/)

Ok.

>> +static struct cpm_pin mgsuvd_pins[] = {
> 
> Make this __initdata, please.

Argh... forgot this.

[...]
>> +static struct of_device_id __initdata of_bus_ids[] = {
> 
> Make this __initdata, please.

Hmm.. it is __initdata, or? But I fix it to:

static  __initdata struct of_device_id of_bus_ids[]

>> +static int __init declare_of_platform_devices(void)
>> +{
>> +	if (!machine_is(mgsuvd))
>> +		return 0;
>> +
>> +	of_platform_bus_probe(NULL, of_bus_ids, NULL);
>> +
>> +	return 0;
>> +}
>> +device_initcall(declare_of_platform_devices);
> 
> This should be "machine_device_initcall(mgsuvd,
> declare_of_platform_devices);" then you don't need the machine_is() check
> above.

Ok

I will send a overworked patch.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany