From: Roel Kluin <12o3l@tiscali•nl>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: lkml <linux-kernel@vger•kernel.org>,
linuxppc-dev@ozlabs•org, Colin Leroy <colin@colino•net>,
akpm@linux-foundation•org, "Darrick J. Wong" <djwong@us•ibm.com>
Subject: Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()
Date: Mon, 10 Mar 2008 23:15:05 +0100 [thread overview]
Message-ID: <47D5B2E9.2030509@tiscali.nl> (raw)
In-Reply-To: <1dd996a5ad3a455c91886cacd3243128@kernel.crashing.org>
Segher Boessenkool wrote:
>> It includes suggested changes by Segher Boessenkool and I think this
>> version was tested by Darrick J. Wong
>
>> - u8 reg;
>> + u8 reg, temp;
>> struct i2c_client *client = to_i2c_client(dev);
>> struct adt7473_data *data = i2c_get_clientdata(client);
>> - int temp = simple_strtol(buf, NULL, 10);
>> - temp = temp && 0xFF;
>> +
>> + temp = simple_strtol(buf, NULL, 10) & 0xFF;
>
> It still does this superfluous "& 0xff", which hides the lack of
> range checking.
Sorry didn't quite grep that
---
logical-bitwise & confusion
Signed-off-by: Roel Kluin <12o3l@tiscali•nl>
---
diff --git a/drivers/hwmon/adt7473.c b/drivers/hwmon/adt7473.c
index 9587869..98937d3 100644
--- a/drivers/hwmon/adt7473.c
+++ b/drivers/hwmon/adt7473.c
@@ -566,11 +566,11 @@ static ssize_t set_max_duty_at_crit(struct device *dev,
const char *buf,
size_t count)
{
- u8 reg;
+ u8 reg, temp;
struct i2c_client *client = to_i2c_client(dev);
struct adt7473_data *data = i2c_get_clientdata(client);
- int temp = simple_strtol(buf, NULL, 10);
- temp = temp && 0xFF;
+
+ temp = simple_strtol(buf, NULL, 10);
mutex_lock(&data->lock);
data->max_duty_at_overheat = temp;
prev parent reply other threads:[~2008-03-10 22:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47D47B11.1000303@tiscali.nl>
[not found] ` <20080310084633.5246ecfe@paperstreet.colino.net>
[not found] ` <1205136413.8621.3.camel@pasglop>
2008-03-10 8:22 ` ADT746X: logical-bitwise & confusion in set_max_duty_at_crit() Roel Kluin
2008-03-10 9:13 ` Segher Boessenkool
2008-03-10 9:59 ` Roel Kluin
2008-03-10 18:13 ` Darrick J. Wong
2008-03-10 21:17 ` Roel Kluin
2008-03-10 21:56 ` Segher Boessenkool
2008-03-10 22:15 ` Roel Kluin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D5B2E9.2030509@tiscali.nl \
--to=12o3l@tiscali$(echo .)nl \
--cc=akpm@linux-foundation$(echo .)org \
--cc=colin@colino$(echo .)net \
--cc=djwong@us$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox