Subject: Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

From: Heiko Schocher <[email-masked]>
Date: Tue, 18 Mar 2008 08:13:06 +0100

Hello Stephen,

Stephen Rothwell wrote:
> On Fri, 14 Mar 2008 10:24:30 +0100 Heiko Schocher <[email-masked]> wrote:
[...]
>> +struct cpm_pin {
>> +		int port, pin, flags;
>> +};
> 
> I wish someone would consolidate all these definitions of cpm_pin.

Hmm... do you mean something like, moving this struct
in cpm1.h and ...

>> +static void __init init_ioports(void)
>> +{
>> +	int i;
>> +
>> +	for (i = 0; i < ARRAY_SIZE(mgsuvd_pins); i++) {
>> +		struct cpm_pin *pin = &mgsuvd_pins[i];
>> +		cpm1_set_pin(pin->port, pin->pin, pin->flags);
>> +	}
> 
> And the code that uses them ...

making in arch/powerpc/sysdev/cpm1.c a function
cpm1_setup_pins (struct cpm_pin *pins) ?

>> +static void __init mgsuvd_setup_arch(void)
>> +{
>> +	struct device_node *cpu;
>> +
>> +	cpu = of_find_node_by_type(NULL, "cpu");
>> +	if (cpu != 0) {
> 
> "cpu" is a pointer, so "cpu != NULL" or just "cpu"
> 
>> +		const unsigned int *fp;
>> +
>> +		fp = of_get_property(cpu, "clock-frequency", NULL);
>> +		if (fp != 0)
> 
> Ditto for "fp" test

Its no longer necessary, thanks to Scott

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany