Subject: Re: muram in device tree for mpc8250 in arch/powerpc

From: Scott Wood <[email-masked]>
Date: Mon, 24 Mar 2008 11:52:22 -0500

James Black wrote:
> Thanks much for the help Scott. Do you feel that the dts is correct
> now and probably not the culprit? Do you have 2.6.24.2 running on
> other boards?

I just booted 2.6.24.2 on pq2fads (using cuImage, since I don't have a 
devtree-aware u-boot on this board).

> 	localbus@f0010100 {
> 		compatible = "fsl,mpc8250-localbus",
>                    "fsl,pq2-localbus";
> 
> 		#address-cells = <2>;
> 		#size-cells = <1>;
> 		reg = <f0010100 60>;
> 		ranges = <0 0 fe000000 00200000>;
> 
> 		flash@fe000000,0 {
> 			compatible = "cfi-flash";
> 			reg = <0 fe000000  00200000>;
> 			bank-width = <2>;
> 			device-width = <1>;
> 		};

This is wrong; the flash will not translate since you didn't provide a 
window at the address reg is at.

The first cell of the reg should be the chipselect, and the second cell 
the offset.

> 			brg@119f0 {
> 				compatible = "fsl,mpc8250-brg",
> 				             "fsl,cpm2-brg",
> 				             "fsl,cpm-brg";
> 				reg = <119f0 10>;
> 			};

BRG should be <119f0 10 115f0 10>.

-Scott