From: Jeff Garzik <jeff@garzik•org>
To: Valentine Barshak <vbarshak@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org, netdev@vger•kernel.org
Subject: Re: [PATCH] ibm_newemac: emac_tx_csum typo fix
Date: Fri, 28 Mar 2008 21:54:06 -0400 [thread overview]
Message-ID: <47EDA13E.3080504@garzik.org> (raw)
In-Reply-To: <20080327144357.GA9111@ru.mvista.com>
Valentine Barshak wrote:
> Move the "&& skb->ip_summed == CHECKSUM_PARTIAL" part out of
> emac_has_feature parameters.
>
> Signed-off-by: Valentine Barshak <vbarshak@ru•mvista.com>
> ---
> drivers/net/ibm_newemac/core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff -pruN linux-2.6.orig/drivers/net/ibm_newemac/core.c linux-2.6/drivers/net/ibm_newemac/core.c
> --- linux-2.6.orig/drivers/net/ibm_newemac/core.c 2008-02-21 16:45:36.000000000 +0300
> +++ linux-2.6/drivers/net/ibm_newemac/core.c 2008-02-22 19:55:29.000000000 +0300
> @@ -1235,8 +1235,8 @@ static int emac_close(struct net_device
> static inline u16 emac_tx_csum(struct emac_instance *dev,
> struct sk_buff *skb)
> {
> - if (emac_has_feature(dev, EMAC_FTR_HAS_TAH &&
> - skb->ip_summed == CHECKSUM_PARTIAL)) {
> + if (emac_has_feature(dev, EMAC_FTR_HAS_TAH) &&
> + (skb->ip_summed == CHECKSUM_PARTIAL)) {
> ++dev->stats.tx_packets_csum;
> return EMAC_TX_CTRL_TAH_CSUM;
applied
prev parent reply other threads:[~2008-03-29 1:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 14:46 [RFC][PATCH] PowerPC 4xx: ibm_newemac 440GX phy clock workaround Valentine Barshak
2008-02-21 22:52 ` Benjamin Herrenschmidt
2008-02-22 19:15 ` Valentine Barshak
2008-02-22 20:51 ` Josh Boyer
2008-02-22 19:24 ` [RFC][PATCH] ibm_newemac: PowerPC 440GX EMAC PHY " Valentine Barshak
2008-02-22 19:28 ` [RFC][PATCH] ibm_newemac: PowerPC 440EP/440GR " Valentine Barshak
2008-02-22 20:49 ` Josh Boyer
2008-02-26 12:25 ` Valentine Barshak
2008-02-26 14:10 ` Steven A. Falco
2008-02-26 15:02 ` Josh Boyer
2008-02-28 7:54 ` Benjamin Herrenschmidt
2008-03-05 17:46 ` Valentine Barshak
2008-03-05 18:38 ` [PATCH] PowerPC 4xx: Add dcri_clrset() for locked read/modify/write functionality Valentine Barshak
2008-03-06 0:06 ` Benjamin Herrenschmidt
2008-03-06 1:12 ` Josh Boyer
2008-03-06 11:31 ` Valentine Barshak
2008-03-06 11:50 ` Benjamin Herrenschmidt
2008-03-06 13:37 ` [PATCH] PowerPC 4xx: Use dcri_clrset() for PCIe indirect dcr read/modify/write access Valentine Barshak
2008-03-06 14:08 ` Valentine Barshak
2008-03-06 14:34 ` Valentine Barshak
2008-03-06 13:41 ` [PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround Valentine Barshak
2008-03-24 23:21 ` Benjamin Herrenschmidt
2008-03-26 12:36 ` Josh Boyer
2008-03-06 13:43 ` [PATCH 2/2] ibm_newemac: PowerPC 440EP/440GR " Valentine Barshak
2008-03-24 23:22 ` Benjamin Herrenschmidt
2008-03-26 12:35 ` Josh Boyer
2008-03-27 13:50 ` Valentine Barshak
2008-03-27 13:53 ` Josh Boyer
2008-03-27 14:40 ` [PATCH 1/2] ibm_newemac: PowerPC 440GX " Valentine Barshak
2008-03-29 2:18 ` Jeff Garzik
2008-03-29 3:28 ` Benjamin Herrenschmidt
2008-03-29 3:30 ` Josh Boyer
2008-04-11 14:24 ` Josh Boyer
2008-04-12 20:28 ` Jeff Garzik
2008-04-12 20:47 ` Josh Boyer
2008-04-12 21:13 ` Jeff Garzik
2008-03-27 14:42 ` [PATCH 2/2] ibm_newemac: PowerPC 440EP/440GR " Valentine Barshak
2008-03-27 14:43 ` [PATCH] ibm_newemac: emac_tx_csum typo fix Valentine Barshak
2008-03-29 1:54 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EDA13E.3080504@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vbarshak@ru$(echo .)mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox