Subject: Re: [patch] PS3: Fix gelic net module dependency

From: Jeff Garzik <[email-masked]>
Date: Wed, 09 Apr 2008 17:42:18 -0400

Geoff Levand wrote:
> The PS3 gelic network driver depends on the wake-on-lan support
> provided by the PS3 sys manager driver.  Add that dependency
> to the GELIC_NET Kconfig option.
> 
> Prevents these build errors:
> 
>   ps3_gelic_net.c:1277: undefined reference to `.ps3_sys_manager_get_wol'
>   ps3_gelic_net.c:1337: undefined reference to `.ps3_sys_manager_set_wol'
> 
> CC: Masakazu Mokuno <[email-masked]>
> CC: Jeff Garzik <[email-masked]>
> Signed-off-by: Geoff Levand <[email-masked]>
> ---
> Hi Paul,
> 
> This fixes an error introduced in my 2.6.26 WOL patches now
> queued in your powerpc tree.  Please apply.
> 
> -Geoff
> 
>  drivers/net/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2358,6 +2358,7 @@ config TSI108_ETH
>  config GELIC_NET
>  	tristate "PS3 Gigabit Ethernet driver"
>  	depends on PPC_PS3
> +	select PS3_SYS_MANAGER
>  	help
>  	  This driver supports the network device on the PS3 game
>  	  console.  This driver has built-in support for Ethernet.

looks sane to me, but I do not have enough knowledge to ACK.  Thanks for 
the CC :)