From: Paul Gortmaker <paul.gortmaker@windriver•com>
To: Timur Tabi <timur@freescale•com>
Cc: linuxppc-dev@ozlabs•org, sfr@canb•auug.org.au
Subject: Re: [PATCH] 86xx: mark functions static, other minor cleanups
Date: Tue, 15 Apr 2008 12:28:52 -0400 [thread overview]
Message-ID: <4804D7C4.8060805@windriver.com> (raw)
In-Reply-To: <4804D39C.9000309@freescale.com>
Timur Tabi wrote:
> Paul Gortmaker wrote:
>
>
>> -void
>> +static void
>> mpc86xx_hpcn_show_cpuinfo(struct seq_file *m)
>> {
>> struct device_node *root;
>> @@ -190,13 +190,13 @@ static int __init mpc86xx_hpcn_probe(void)
>> {
>> unsigned long root = of_get_flat_dt_root();
>>
>> - if (of_flat_dt_is_compatible(root, "mpc86xx"))
>> + if (of_flat_dt_is_compatible(root, "fsl,mpc86xx"))
>> return 1; /* Looks good */
>>
>
> This breaks compatibility with older device trees. You still need to look for
> "mpc86xx".
>
> A lot of people have been doing this recently, and it needs to stop. You need
> to wait at least one whole kernel version before you can remove support for an
> older device tree.
>
Valid point. Is there a precedent here -- like a printk indicating
that the old ID matched, to let the user know?
>
>> -void
>> +static void
>> sbc8641_show_cpuinfo(struct seq_file *m)
>> {
>> struct device_node *root;
>> @@ -118,13 +111,13 @@ static int __init sbc8641_probe(void)
>> {
>> unsigned long root = of_get_flat_dt_root();
>>
>> - if (of_flat_dt_is_compatible(root, "mpc86xx"))
>> + if (of_flat_dt_is_compatible(root, "wrs,sbc8641"))
>> return 1; /* Looks good */
>>
>
> Same here.
>
Actually on this one, we are OK, since the board support didn't exist
in the default kernel until I'd just sent it last week.
Thanks,
Paul.
next prev parent reply other threads:[~2008-04-15 16:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 16:59 [PATCH] 86xx: mark functions static, other minor cleanups Paul Gortmaker
2008-04-11 17:16 ` Scott Wood
2008-04-11 18:43 ` Paul Gortmaker
2008-04-11 19:11 ` Segher Boessenkool
2008-04-15 1:32 ` Paul Gortmaker
2008-04-18 0:35 ` David Gibson
2008-04-11 18:28 ` Segher Boessenkool
2008-04-15 16:11 ` Timur Tabi
2008-04-15 16:28 ` Paul Gortmaker [this message]
2008-04-15 16:31 ` Timur Tabi
2008-04-15 22:46 ` Paul Gortmaker
2008-04-15 23:01 ` Kumar Gala
2008-04-15 23:24 ` Kumar Gala
2008-04-16 17:53 ` [PATCH 1/2] " Paul Gortmaker
2008-04-16 17:53 ` [PATCH 2/2] mpc86xx_hpcn: Temporarily accept old dts node identifier Paul Gortmaker
2008-04-17 14:57 ` Kumar Gala
2008-04-17 14:57 ` [PATCH 1/2] 86xx: mark functions static, other minor cleanups Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4804D7C4.8060805@windriver.com \
--to=paul.gortmaker@windriver$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox