Subject: Re: build breakage from of i2c helper patch

From: Jochen Friedrich <[email-masked]>
Date: Thu, 17 Apr 2008 11:25:12 +0200

Hi Kumar,

> I'm guessing the "[POWERPC] i2c: OF helpers for the i2c API"
> 
> http://git.kernel.org/?p=linux/kernel/git/paulus/powerpc.git;a=commitdiff;h=612212a3f2f053ea68ce9cd16d3deeca7754e8c9
> 
> is causing this build failure:
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/24375/

It looks like it. i2c-core needs to be compiled static for the OF bindings to work.
I guess in Kconfig "depends on OF && I2C" must be changed into "depends on OF && (I2C=y)"

On the other hand, i didn't test the patch without the dependent patches, so it might not work as expected:

http://patchwork.ozlabs.org/linuxppc/patch?id=17833
http://patchwork.ozlabs.org/linuxppc/patch?id=17834

or the original ones from Jean Delvare:

http://patchwork.ozlabs.org/linuxppc/patch?id=16282
http://patchwork.ozlabs.org/linuxppc/patch?id=16283
http://patchwork.ozlabs.org/linuxppc/patch?id=16284

Thanks,
Jochen