From: Matt Sealey <matt@genesi-usa•com>
To: David Woodhouse <dwmw2@infradead•org>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [EFIKA] Really, don't pretend to be CHRP
Date: Thu, 17 Apr 2008 13:28:43 +0100 [thread overview]
Message-ID: <4807427B.3030902@genesi-usa.com> (raw)
In-Reply-To: <1208105558.3026.137.camel@pmac.infradead.org>
I thought we were using efika.forth for this in Fedora.
Why don't we just roll all those fixes into prom_efika.c or something
and make it a huge, unwieldy file nice and *seperate* from prom_init.c?
:)
--
Matt Sealey <matt@genesi-usa•com>
Genesi, Manager, Developer Relations
David Woodhouse wrote:
> Fedora 9 works on Efika without the separate 'device-tree supplement',
> thanks to the kernel's own fixups. With one exception -- because 'CHRP'
> still appears on the 'machine:' line in /proc/cpuinfo, the installer
> misdetects the platform and misconfigures yaboot, putting it into a PReP
> boot partition instead of in the /boot filesystem where the Efika's
> firmware could find it.
>
> The kernel's fixups for Efika already correct one instance of 'chrp', in
> the 'device_type' property. This fixes it in the 'CODEGEN,description'
> property too, since that's what's exposed to userspace in /proc/cpuinfo.
>
> Signed-off-by: David Woodhouse <dwmw2@infradead•org>
>
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 5ab4c84..723422e 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -2240,6 +2240,14 @@ static void __init fixup_device_tree_efika(void)
> if (rv != PROM_ERROR && (strcmp(prop, "chrp") == 0))
> prom_setprop(node, "/", "device_type", "efika", sizeof("efika"));
>
> + /* CODEGEN,description is exposed in /proc/cpuinfo so
> + fix that too */
> + rv = prom_getprop(node, "CODEGEN,description", prop, sizeof(prop));
> + if (rv != PROM_ERROR && (strstr(prop, "CHRP")))
> + prom_setprop(node, "/", "CODEGEN,description",
> + "Efika 5200B PowerPC System",
> + sizeof("Efika 5200B PowerPC System"));
> +
> /* Fixup bestcomm interrupts property */
> node = call_prom("finddevice", 1, 1, ADDR("/builtin/bestcomm"));
> if (PHANDLE_VALID(node)) {
>
>
>
next prev parent reply other threads:[~2008-04-17 12:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-13 16:52 [EFIKA] Really, don't pretend to be CHRP David Woodhouse
2008-04-14 2:54 ` Grant Likely
2008-04-17 12:28 ` Matt Sealey [this message]
2008-04-17 14:37 ` David Woodhouse
2008-04-17 15:17 ` Matt Sealey
2008-04-17 16:37 ` David Woodhouse
2008-04-18 15:33 ` Matt Sealey
2008-04-19 0:53 ` Benjamin Herrenschmidt
2008-04-18 0:17 ` David Gibson
2008-04-18 8:24 ` Benjamin Herrenschmidt
2008-04-18 15:21 ` Matt Sealey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4807427B.3030902@genesi-usa.com \
--to=matt@genesi-usa$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox