Subject: Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

From: Timur Tabi <[email-masked]>
Date: Thu, 17 Apr 2008 17:00:20 -0500

Anton Vorontsov wrote:

> static inline bool qe_clock_is_brg(enum qe_clock clk)
> {
> 	return clk < QE_CLK1;
> }

I have no problem with this function (the UART driver could use it), except that
your implementation is wrong.  You would need to do this:

static inline bool qe_clock_is_brg(enum qe_clock clk)
{
	return (clk >= QE_BRG1) && (clk <= QE_BRG16);
}

-- 
Timur Tabi
Linux kernel developer at Freescale