From: Peter Czanik <pczanik@fang•fa.gau.hu>
To: Juergen Beisert <jbe@pengutronix•de>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: RFC: MPC5200 PSC AC97 driver
Date: Fri, 18 Apr 2008 17:43:58 +0200 [thread overview]
Message-ID: <4808C1BE.1050607@fang.fa.gau.hu> (raw)
In-Reply-To: <200804171619.56615.jbe@pengutronix.de>
Hello,
Juergen Beisert írta:
> Hi,
>
> if someone is interested: Here the full patch to get sound support for
> MPC5200b and a current 2.6.25 kernel.
>
First of all, thanks for fixing the driver. I just tested it on the
EFIKA, it (almost) works. In its current state loading the kernel module
results in a segfault and oops. The fix is to add a missing line to the
device-tree. The forth version of the EFIKA fix works fine (taken from
http://www.powerdeveloper.org/platforms/efika/devicetree ):
efika:~ # cat /mnt/sound.forth
\ FORTH
s" /builtin/sound" find-device
\ Audio is on PSC2, just for informational purposes
1 encode-int s" cell-index" property
device-end
efika:~ #
But trying to fix it up from prom_init.c does not seem to work, the
missing 'cell-index' property does not show up. Please let me know, how
to add it properly. Here is what I tried:
factory:/usr/src/linux-2.6.25 # diff -u
arch/powerpc/kernel/prom_init.c.orig arch/powerpc/kernel/prom_init.c
--- arch/powerpc/kernel/prom_init.c.orig 2008-04-18
13:55:07.000000000 +0200
+++ arch/powerpc/kernel/prom_init.c 2008-04-18 16:26:51.000000000 +0200
@@ -2212,6 +2212,7 @@
static void __init fixup_device_tree_efika(void)
{
+ int sound_ci = 1;
int sound_irq[3] = { 2, 2, 0 };
int bcomm_irq[3*16] = { 3,0,0, 3,1,0, 3,2,0, 3,3,0,
3,4,0, 3,5,0, 3,6,0, 3,7,0,
@@ -2257,6 +2258,8 @@
rv = prom_getprop(node, "interrupts", prop, sizeof(prop));
if (rv == PROM_ERROR) {
prom_printf("Adding sound interrupts property\n");
+ prom_setprop(node, "/builtin/sound", "cell-index",
+ &sound_ci, sizeof(int));
prom_setprop(node, "/builtin/sound", "interrupts",
sound_irq, sizeof(sound_irq));
}
factory:/usr/src/linux-2.6.25 #
Bye,
CzP
next prev parent reply other threads:[~2008-04-18 15:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 10:44 State of the MPC5200 PSC AC97 driver Marian Balakowicz
2008-04-10 13:50 ` Robert Schwebel
2008-04-10 15:25 ` Matt Sealey
2008-04-11 6:51 ` Robert Schwebel
2008-04-11 7:34 ` Sven Luther
2008-04-11 7:29 ` Sylvain Munaut
2008-04-15 8:03 ` Juergen Beisert
2008-04-16 11:24 ` Juergen Beisert
2008-04-17 14:19 ` RFC: " Juergen Beisert
2008-04-17 14:23 ` Matt Sealey
2008-04-17 14:41 ` Juergen Beisert
2008-04-17 14:54 ` Matt Sealey
2008-04-17 15:05 ` Matt Sealey
2008-04-17 15:23 ` Juergen Beisert
2008-04-17 15:10 ` Matt Sealey
2008-04-17 15:23 ` Juergen Beisert
2008-04-17 15:43 ` Matt Sealey
2008-04-17 15:46 ` Sergei Shtylyov
2008-04-18 15:43 ` Peter Czanik [this message]
2008-04-18 16:02 ` Juergen Beisert
2008-04-18 18:11 ` Matt Sealey
2008-04-18 22:53 ` Grant Likely
2008-04-19 12:02 ` Matt Sealey
2008-04-19 15:59 ` Grant Likely
2008-04-21 8:02 ` Juergen Beisert
2008-04-21 17:04 ` Matt Sealey
2008-04-19 16:03 ` Grant Likely
2008-04-22 14:20 ` Olaf Hering
2008-04-11 9:23 ` State of the " Marian Balakowicz
2008-04-11 13:50 ` Grant Likely
2008-04-11 14:53 ` Marian Balakowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4808C1BE.1050607@fang.fa.gau.hu \
--to=pczanik@fang$(echo .)fa.gau.hu \
--cc=jbe@pengutronix$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox