From: Roel Kluin <12o3l@tiscali•nl>
To: galak@kernel•crashing.org, linuxppc-dev@ozlabs•org
Cc: spi-devel-general@lists•sourceforge.net,
dbrownell@users•sourceforge.net,
lkml <linux-kernel@vger•kernel.org>
Subject: [PATCH 1/2] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe()
Date: Wed, 23 Apr 2008 22:55:16 +0200 [thread overview]
Message-ID: <480FA234.1000601@tiscali.nl> (raw)
mpc83xx_spi->irq is unsigned, so the test fails
Signed-off-by: Roel Kluin <12o3l@tiscali•nl>
---
diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
index be15a62..033fd51 100644
--- a/drivers/spi/spi_mpc83xx.c
+++ b/drivers/spi/spi_mpc83xx.c
@@ -454,12 +454,12 @@ static int __init mpc83xx_spi_probe(struct platform_device *dev)
goto put_master;
}
- mpc83xx_spi->irq = platform_get_irq(dev, 0);
-
- if (mpc83xx_spi->irq < 0) {
- ret = -ENXIO;
+ ret = platform_get_irq(dev, 0);
+ if (ret < 0)
goto unmap_io;
- }
+
+ mpc83xx_spi->irq = ret;
+ ret = 0;
/* Register for SPI Interrupt */
ret = request_irq(mpc83xx_spi->irq, mpc83xx_spi_irq,
next reply other threads:[~2008-04-23 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 20:55 Roel Kluin [this message]
2008-04-23 21:55 ` [PATCH 1/2] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe() Joakim Tjernlund
2008-04-25 11:25 ` Joakim Tjernlund
2008-05-07 22:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480FA234.1000601@tiscali.nl \
--to=12o3l@tiscali$(echo .)nl \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=spi-devel-general@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox