From: Andrew Liu <shengping.liu@windriver•com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] [POWERPC] Uniformly use memstart_addr variable as the start address of physical memory in powerpc branch
Date: Wed, 21 May 2008 11:22:18 +0900 [thread overview]
Message-ID: <4833875A.9090006@windriver.com> (raw)
In-Reply-To: <BEDAF2CE-73A5-4FE4-848B-936B7D675131@kernel.crashing.org>
Kumar Gala wrote:
>
> On May 20, 2008, at 8:38 PM, Andrew Liu wrote:
>
>> [POWERPC]: Uniformly use memstart_addr as the start address of RAM
>>
>> The variable: memstart_addr whose initial value is got from dts file
>> is used as the start address of physical memory in PowerPC ARCH,
>> although it is used in functions: mapin_ram(pgtable_32.c) and
>> cam_mapin_ram(fsl_booke_mmu.c), however, in function: mmu_mapin_ram
>> (ppc_mmu_32.c), use 0 as the start address of physical memory, so
>> it is necessary to unify them: in mmu_mapin_ram, use memstart_addr
>> as the start address of physical memory, instead of 0.
>>
>> Signed-off-by: Andrew Liu <shengping.liu@windriver•com>
>> ---
>
> Do you have a case where this is non-zero for ppc_mmu_32? I left these
> alone because I wasn't aware of one (or if its reasonable).
>
No.
I submitted this patch just because in ppc branch, PPC_MEMSTART is used as
the start address of physical memory uniformly, however, in powerpc branch,
use memstart_addr and 0, although, almost for all boards which are in powerpc,
they are equal, from the aspect of code consistency, I think it is necessary to
unify them.
You know we can't make sure in future the start address of all incoming
boards' RAM is 0, especially, in AMP system, different cpu uses the different RAM area,
definitely, the start address of some is not 0.
BRs,
Andrew
> - k
>
>
next prev parent reply other threads:[~2008-05-21 3:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 1:38 [PATCH] [POWERPC] Uniformly use memstart_addr variable as the start address of physical memory in powerpc branch Andrew Liu
2008-05-21 3:11 ` Kumar Gala
2008-05-21 2:22 ` Andrew Liu [this message]
2008-05-21 4:14 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4833875A.9090006@windriver.com \
--to=shengping.liu@windriver$(echo .)com \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox