From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Paul Mackerras <paulus@samba•org>
Cc: "linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>
Subject: Re: [patch v2] PS3: Fix memory hotplug
Date: Wed, 21 May 2008 09:41:55 -0700 [thread overview]
Message-ID: <483450D3.7050900@am.sony.com> (raw)
In-Reply-To: <482C9897.90709@am.sony.com>
Geoff Levand wrote:
> A change was made to walk_memory_resource() in commit
> 4b119e21d0c66c22e8ca03df05d9de623d0eb50f that added a
> check of find_lmb(). Add the coresponding lmb_add()
> call to ps3_mm_add_memory() so that that check will
> succeed.
>
> This fixes the condition where the PS3 boots up with
> only the 128 MiB of boot memory.
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
> ---
>
> v2: Add call to lmb_analyze().
>
> arch/powerpc/platforms/ps3/mm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- a/arch/powerpc/platforms/ps3/mm.c
> +++ b/arch/powerpc/platforms/ps3/mm.c
> @@ -317,6 +317,9 @@ static int __init ps3_mm_add_memory(void
> return result;
> }
>
> + lmb_add(start_addr, map.r1.size);
> + lmb_analyze();
> +
> result = online_pages(start_pfn, nr_pages);
>
> if (result)
>
Hi Paul,
Could you please merge this one in for 2.6.26. Without it the
system boots with just 128 of the total 256 MiB of memory.
There is the concurrency problem as Ben commented on, but I
think not having the 128 MiB of memory is worse than having the
potential race, which we can work on as a separate fix.
-Geoff
prev parent reply other threads:[~2008-05-21 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 16:23 PS3: Fix memory hotplug Geoff Levand
2008-05-15 6:48 ` Benjamin Herrenschmidt
2008-05-15 6:51 ` Benjamin Herrenschmidt
2008-05-15 7:02 ` David Miller
2008-05-20 0:40 ` [rfc] [patch] LMB: Add basic spin locking to lmb Geoff Levand
2008-05-20 0:55 ` [patch v2] " Geoff Levand
2008-05-20 2:22 ` David Miller
2008-05-20 2:32 ` Benjamin Herrenschmidt
2008-05-20 2:34 ` David Miller
2008-05-15 9:38 ` PS3: Fix memory hotplug Paul Mackerras
2008-05-21 18:31 ` Geoff Levand
2008-05-15 20:09 ` [patch v2] " Geoff Levand
2008-05-21 16:41 ` Geoff Levand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483450D3.7050900@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox