Subject: Re: [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver

From: Scott Wood <[email-masked]>
Date: Fri, 30 May 2008 15:19:43 -0500

Kim Phillips wrote:
> On Fri, 30 May 2008 14:41:17 -0500
> Scott Wood <[email-masked]> wrote:
> 
>> Kim Phillips wrote:
>>> On Fri, 30 May 2008 22:09:04 +0400
>>> Evgeniy Polyakov <[email-masked]> wrote:
>>>> Don't you want to protect against simultaneous access to register space
>>>> from different CPUs? Or it is single processor board only?
>>> Doesn't linux mask the IRQ line for the interrupt currently being
>>> serviced, and on all processors?
>> Yes.  Could there be interference from non-interrupt driver code on 
>> another cpu (or interrupted code), though?
> 
> not that I can see - the fetch fifo register writes are protected with
> per-channel spinlocks.

But you don't take the spinlocks from the interrupt handler.

-Scott