Subject: Re: [PATCH] phylib: Don't allow core of phylib to build as a module

From: Jeff Garzik <[email-masked]>
Date: Mon, 02 Jun 2008 12:03:58 -0400

Kumar Gala wrote:
> The core portions of the phylib aren't capable of being used as
> a module.  This isn't really any different than something like i2c
> in that the bus driver and core need to be built into the kernel.
> 
> Signed-off-by: Kumar Gala <[email-masked]>
> ---
> 
> Jeff, please consider this for 2.6.26 as w/o it we get build issues
> if phylib is config'd as a module on ppc.
> 
>  drivers/net/phy/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index 6eb2d31..ab04cc7 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -3,7 +3,7 @@
>  #
> 
>  menuconfig PHYLIB
> -	tristate "PHY Device support and infrastructure"
> +	bool "PHY Device support and infrastructure"
>  	depends on !S390
>  	depends on NET_ETHERNET

What are the issues?

The core _should_ be able to be built as a module.

	Jeff