From: Wolfgang Grandegger <wg@grandegger•com>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: Linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] booting-without-of: add more bindings for FSL UPM driver
Date: Mon, 09 Jun 2008 17:19:27 +0200 [thread overview]
Message-ID: <484D49FF.4090604@grandegger.com> (raw)
In-Reply-To: <519f1a6d9baeca8cfea9e8ad7a92c4d4@kernel.crashing.org>
Segher Boessenkool wrote:
>> + - chip-delay : may specify a delay value in milliseconds.
>
> Delay for what? The binding should say. "chip-delay" is a bit
> too generic name as well, it could be more descriptive perhaps.
The chip-delay property defines an appropriate maximum delay
time (tR) required for read operations if the R/B pin is not
connected. It's used as shown below:
+ /* Note: NAND support needs to be enabled in U-Boot */
+ upm@3,0 {
+ #address-cells = <0>;
+ #size-cells = <0>;
+ compatible = "fsl,upm-nand";
+ reg = <3 0x0 0x800>;
+ fsl,upm-addr-offset = <0x10>;
+ fsl,upm-cmd-offset = <0x08>;
+ chip-delay = <25>; // in micro-seconds
+
+ nand@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "fs";
+ reg = <0x00000000 0x01000000>;
+ };
+ };
+ };
+ };
+
> Shouldn't this be a property of the NAND device anyway, not the
> NAND controller?
Strictly speaking, it's a property of the NAND device. Therefore it
should be inside the node nand@0, I thhink:
+ nand@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ chip-delay = <25>; // in micro-seconds
+
+ partition@0 {
+ label = "fs";
+ reg = <0x00000000 0x01000000>;
+ };
+ };
Where should that be documented?
Wolfgang.
next prev parent reply other threads:[~2008-06-09 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 8:42 [PATCH] booting-without-of: add more bindings for FSL UPM driver Wolfgang Grandegger
2008-06-09 10:30 ` Segher Boessenkool
2008-06-09 15:19 ` Wolfgang Grandegger [this message]
2008-06-09 23:47 ` Segher Boessenkool
2008-06-12 8:10 ` Wolfgang Grandegger
2008-06-26 13:07 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484D49FF.4090604@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox