Subject: Re: [PATCH] [8xx] powerpc: Add support for the MPC852 based mgsuvd board from keymile.

From: Scott Wood <[email-masked]>
Date: Fri, 13 Jun 2008 10:51:23 -0500

Heiko Schocher wrote:
> +	localbus@fff00100 {
> +		compatible = "fsl,pq1-localbus";

"fsl,mpc852-localbus", "fsl,pq1-localbus", "simple-bus";

> +	soc@fff00000 {
> +		compatible = "fsl,mpc852", "simple-bus", "fsl,pq1-soc";

simple-bus should come last, since it's the most generic.

> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		device_type = "soc";
> +		ranges = <0 0xfff00000 0x00004000>;
> +
> +		PIC: interrupt-controller@0 {
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			reg = <0 24>;
> +			compatible = "fsl,pq1-pic";

"fsl,mpc852-pic", "fsl,pq1-pic";

In general, a chip-specific name should be listed first, so the driver 
can easily apply workarounds if needed.  See the existing 8xx device 
trees for examples.

-Scott