Subject: Re: [PATCH 5/6] MPC5121 Add PCI support

From: Scott Wood <[email-masked]>
Date: Fri, 20 Jun 2008 17:17:49 -0500

Kumar Gala wrote:
>> diff --git a/arch/powerpc/platforms/512x/pci.c 
>> b/arch/powerpc/platforms/512x/pci.c
>> new file mode 100644
>> index 0000000..7ed9b34
>> --- /dev/null
>> +++ b/arch/powerpc/platforms/512x/pci.c
>> @@ -0,0 +1,84 @@
>> +/*
>> + * Copyright (C) 2008 Freescale Semiconductor, Inc. All rights reserved.
>> + *
>> + * Original copied from 83xx/pci.c:
> 
> Can we not reuse the same code for 83xx/pci.c and 5121/pci?  and move it 
> into sysdev/fsl_pci.c?  (we'd add some ifdefs for 83xx & 5121)

I assume by "ifdefs" you mean "device tree checks", right? :-)

-Scott