From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: John Rigby <jrigby@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 8/8][Version 2] MPC5121 Hide pci bridge
Date: Wed, 25 Jun 2008 01:41:33 +0400 [thread overview]
Message-ID: <48616A0D.4000306@ru.mvista.com> (raw)
In-Reply-To: <1214342672-23536-9-git-send-email-jrigby@freescale.com>
Hello.
John Rigby wrote:
> The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER
> while other freescale host bridges have class set to
> PCI_CLASS_PROCESSOR_POWERPC.
>
> This patch makes fixup_hide_host_resource_fsl match
> PCI_CLASS_BRIDGE_OTHER in addition to PCI_CLASS_PROCESSOR_POWERPC.
>
> Signed-off-by: John Rigby <jrigby@freescale•com>
>
> diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/pci_32.c
> index 88db4ff..3d33935 100644
> --- a/arch/powerpc/kernel/pci_32.c
> +++ b/arch/powerpc/kernel/pci_32.c
> @@ -54,11 +54,12 @@ LIST_HEAD(hose_list);
> static int pci_bus_count;
>
> static void
> -fixup_hide_host_resource_fsl(struct pci_dev* dev)
> +fixup_hide_host_resource_fsl(struct pci_dev *dev)
> {
> int i, class = dev->class >> 8;
>
> - if ((class == PCI_CLASS_PROCESSOR_POWERPC) &&
> + if ((class == PCI_CLASS_PROCESSOR_POWERPC
> + || class == PCI_CLASS_BRIDGE_OTHER) &&
>
Coding style nit: could you put || on the same line with first
comparison (where && used to be BTW) and align the second comparison to
start under 'class'?
WBR, Sergei
next prev parent reply other threads:[~2008-06-24 21:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 21:24 [PATCH 0/8][Version 2] MPC5121 Updates John Rigby
[not found] ` <1214342672-23536-2-git-send-email-jrigby@freescale.com>
2008-06-24 21:24 ` [PATCH 2/8][Version 2] MPC5121 clock driver John Rigby
2008-06-24 21:24 ` [PATCH 3/8][Version 2] MPC5121 Add generic board support John Rigby
2008-06-24 21:24 ` [PATCH 4/8][Version 2] MPC5121 Add MPC5121ADS cpld support John Rigby
2008-06-24 21:24 ` [PATCH 5/8][Version 2] powerpc: pci config cleanup John Rigby
2008-06-24 21:24 ` [PATCH 6/8][Version 2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c John Rigby
2008-06-24 21:24 ` [PATCH 7/8][Version 2] MPC5121 Add PCI support John Rigby
2008-06-24 21:24 ` [PATCH 8/8][Version 2] MPC5121 Hide pci bridge John Rigby
2008-06-24 21:41 ` Sergei Shtylyov [this message]
2008-06-25 17:17 ` [PATCH 6/8][Version 2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c Kumar Gala
2008-06-29 8:01 ` [PATCH 3/8][Version 2] MPC5121 Add generic board support Grant Likely
2008-06-25 6:31 ` [PATCH 2/8][Version 2] MPC5121 clock driver David Jander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48616A0D.4000306@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=jrigby@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox