From: Jochen Friedrich <jochen@scram•de>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: Scott Wood <scottwood@freescale•com>,
linuxppc-dev list <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH2/2] [POWERPC] CPM1: implement GPIO LIB API on CPM1 Freescale SoC.
Date: Tue, 01 Jul 2008 17:40:46 +0200 [thread overview]
Message-ID: <486A4FFE.6020407@scram.de> (raw)
In-Reply-To: <fa686aa40804210730s2f356d92ib4247423d55911cd@mail.gmail.com>
Hi Grant,
sorry for the late response on this one.
> 2. You need to specifiy exact chip names in your compatible string.
> "fsl,cpm1-pario-<bank>" is a made up thing.
>> + for_each_compatible_node(np, NULL, "fsl,cpm1-pario-bank16")
>> + cpm1_gpiochip_add16(np);
>> +
>> + for_each_compatible_node(np, NULL, "fsl,cpm1-pario-bank32b")
>> + cpm1_gpiochip_add32(np);
>> +
>> + /* Port E uses CPM2 layout */
>> + for_each_compatible_node(np, NULL, "fsl,cpm1-pario-bank32e")
>> + cpm2_gpiochip_add32(np);
What do you suggest here?
All GPIO ports of CPM1/CPM2 are on the SoC, so the chip name is in fact the CPU itself
(like fsl,mpc866-pario-bank16).
Thanks,
Jochen
next prev parent reply other threads:[~2008-07-01 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 17:10 [PATCH2/2] [POWERPC] CPM1: implement GPIO LIB API on CPM1 Freescale SoC Jochen Friedrich
2008-04-21 14:30 ` Grant Likely
2008-07-01 15:40 ` Jochen Friedrich [this message]
2008-07-01 16:36 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486A4FFE.6020407@scram.de \
--to=jochen@scram$(echo .)de \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox