Subject: Re: [PATCH 1/3] mpc83xx: Power Management support

From: Scott Wood <[email-masked]>
Date: Wed, 02 Jul 2008 12:12:03 -0500

Kumar Gala wrote:
>> +#define SS_MEMSAVE    0x00
> 
> What is this? add a comment?

There's a comment where MEMSAVE is used:

         /* The first 2 words of memory are used to communicate with the
          * bootloader, to tell it how to resume.
          *
          * The first word is the magic number 0xf5153ae5, and the second
          * is the pointer to mpc83xx_deep_resume.
          *
          * The original content of these two words is saved in the state
          * save area.
          */

We could stick a /* First 8 bytes of RAM */ after the #define if you want.

>> +#define SS_HID        0x08 /* 3 HIDs */
>> +#define SS_IABR        0x14 /* 2 IABRs */
>> +#define SS_IBCR        0x1c
>> +#define SS_DABR        0x20 /* 2 DABRs */
>> +#define SS_DBCR        0x28
>> +#define SS_SP        0x2c
>> +#define SS_SR        0x30 /* 16 segment registers */
>> +#define SS_CURRENT    0x70
> 
> How about SS_R2 to match the pmac sleep.S code.  It will make 
> refactoring all this easier in the future.

OK.

-Scott