Subject: Re: [PATCH 1/3] mpc83xx: Power Management support

From: Scott Wood <[email-masked]>
Date: Wed, 02 Jul 2008 12:46:55 -0500

Kumar Gala wrote:
> 
> On Jul 2, 2008, at 12:12 PM, Scott Wood wrote:
> 
>> Kumar Gala wrote:
>>>> +#define SS_MEMSAVE    0x00
>>> What is this? add a comment?
>>
>> There's a comment where MEMSAVE is used:
>>
>>        /* The first 2 words of memory are used to communicate with the
> 
> I read this as the memory address 0, 0x4.  do you mean the first two 
> words of the save area?

Both.  Memory addresses 0 and 4 are saved in the first two words of the 
save area, so that we can overwrite the former with the magic number and 
resume address.

>>
>>         * bootloader, to tell it how to resume.
>>         *
>>         * The first word is the magic number 0xf5153ae5, and the second
>>         * is the pointer to mpc83xx_deep_resume.
>>         *
>>         * The original content of these two words is saved in the state
>>         * save area.
>>         */
>>
>> We could stick a /* First 8 bytes of RAM */ after the #define if you 
>> want.
> 
> ahh, might be useful to add SS_MEMSAVE into the comment.

OK.

-Scott