From: Wolfgang Grandegger <wg@grandegger•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: Jean Delvare <khali@linux-fr•org>, Linuxppc-dev@ozlabs•org
Subject: Re: [RFC] I2C: fsl-i2c: make device probing configurable via FDT
Date: Wed, 16 Jul 2008 22:20:06 +0200 [thread overview]
Message-ID: <487E57F6.7020602@grandegger.com> (raw)
In-Reply-To: <20080716142436.GD24045@secretlab.ca>
Grant Likely wrote:
> On Wed, Jul 16, 2008 at 12:47:25PM +0200, Wolfgang Grandegger wrote:
>> Currently, the I2C buses are probed for HWMON I2C devices, which might
>> not be acceptable in same cases. This patch makes device probing
>> configurable through the property "probe" of the FDT I2C device node:
>>
>> i2c@3000 {
>> ...
>> compatible = "fsl-i2c";
>> probe;
>> ...
>> };
>
> You need to add documentation to booting-without-of.txt about what the
> 'probe' property means. Also, 'probe' is a pretty generic term being
> used in an i2c specific context. Can you prefix it with i2c or
> something to protect the namespace? 'i2c-probe' perhaps?
Of course, no problem. I'm also aware of booting-without-of.txt but
first I wanted to bring up the problem-
>
>> Assuming that systems using fsl-i2c should have proper platform data,
>> probing is disabled by default. Unfortunately, that's not the case and
>> various DTS files would require to be updated.
>
> This comment doesn't seem to be correct.
Well, maybe it's due to my bad English. What I wanted to say is that by
default probing should be disabled. But that requires various DTS files
to be fixed.
>
>> ---
>> arch/powerpc/sysdev/fsl_soc.c | 4 ++++
>> drivers/i2c/busses/i2c-mpc.c | 17 ++++++++++++++---
>> include/linux/fsl_devices.h | 1 +
>
> This will need to be reworked for current top of tree. i2c-mpc
> dependence on fsl_soc.c has been removed.
I kown. Will prepare a new patch a.s.a.p.
Wolfgang.
next prev parent reply other threads:[~2008-07-16 20:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 10:47 [RFC] I2C: fsl-i2c: make device probing configurable via FDT Wolfgang Grandegger
2008-07-16 12:05 ` Jean Delvare
2008-07-16 13:03 ` Wolfgang Grandegger
2008-07-16 12:47 ` Jon Smirl
2008-07-16 13:09 ` Wolfgang Grandegger
2008-07-16 14:11 ` Jon Smirl
2008-07-16 14:24 ` Jon Smirl
2008-07-16 14:30 ` Grant Likely
2008-07-16 14:42 ` Jon Smirl
2008-07-16 15:01 ` Timur Tabi
2008-07-16 14:24 ` Grant Likely
2008-07-16 14:48 ` Jochen Friedrich
2008-07-16 20:20 ` Wolfgang Grandegger [this message]
2008-07-17 10:20 ` Is there relationship between address translation enabled and PLB timeout error? Evangelion
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487E57F6.7020602@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=khali@linux-fr$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox