From: Wolfgang Grandegger <wg@grandegger•com>
To: Jean Delvare <khali@linux-fr•org>
Cc: Linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] i2c-mpc: suppress I2C device probing
Date: Thu, 07 Aug 2008 12:20:25 +0200 [thread overview]
Message-ID: <489ACC69.5070701@grandegger.com> (raw)
In-Reply-To: <20080807102126.5980c761@hyperion.delvare>
Jean Delvare wrote:
> Hi Grant, Wolgang,
>
> On Thu, 17 Jul 2008 12:02:50 -0600, Grant Likely wrote:
>> On Thu, Jul 17, 2008 at 4:37 AM, Wolfgang Grandegger <wg@grandegger•com> wrote:
>>> This patch suppresses I2C device probing by clearing the class field
>>> of the "struct i2c_adapter" for the MPC I2C bus adapters. Some board
>>> configurations which rely on probing must be fixed up by adding a
>>> proper I2C device node to the DTS file, like the TQM85xx modules.
>>>
>>> Signed-off-by: Wolfgang Grandegger <wg@grandegger•com>
>> Acked-by: Grant Likely <grant.likely@secretlab•ca>
>>
>>> ---
>>> drivers/i2c/busses/i2c-mpc.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> Index: powerpc/drivers/i2c/busses/i2c-mpc.c
>>> ===================================================================
>>> --- powerpc.orig/drivers/i2c/busses/i2c-mpc.c
>>> +++ powerpc/drivers/i2c/busses/i2c-mpc.c
>>> @@ -312,7 +312,6 @@ static struct i2c_adapter mpc_ops = {
>>> .name = "MPC adapter",
>>> .id = I2C_HW_MPC107,
>>> .algo = &mpc_algo,
>>> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
>>> .timeout = 1,
>>> };
>
> Unless you intend to push this patch upstream yourself (through the ppc
> tree), you should send it to Ben Dooks (who is in charge of this part
> of the i2c subsystem) with Cc to the i2c list.
I just want to mention, that other I2 bus drivers set I2C_CLASS_HWMON as well.
Here are the PowerPC related ones:
$ grep I2C_CLASS_HWMON *
i2c-cpm.c: .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
i2c-mpc.c: .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
i2c-ibm_iic.c: adap->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
i2c-pasemi.c: smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
i2c-mv64xxx.c: drv_data->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
It would be consequent to remove them as well.
Wolfgang.
next prev parent reply other threads:[~2008-08-07 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 10:37 [PATCH] i2c-mpc: suppress I2C device probing Wolfgang Grandegger
2008-07-17 18:02 ` Grant Likely
2008-08-07 8:21 ` Jean Delvare
2008-08-07 10:20 ` Wolfgang Grandegger [this message]
2008-08-07 10:50 ` Jochen Friedrich
2008-08-07 11:07 ` Jean Delvare
2008-08-07 14:33 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489ACC69.5070701@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=khali@linux-fr$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox