public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Kevin Diggs <kevdig@hypersurf•com>
To: linuxppc-dev@ozlabs•org
Subject: details, details ...
Date: Wed, 13 Aug 2008 05:01:46 -0700	[thread overview]
Message-ID: <48A2CD2A.5020107@hypersurf.com> (raw)

Hi,

In cpu exit function of a cpufreq driver:

         while (test_bit(cf750gxmChangingPllBit, &cf750gxvStateBits))
                 msleep(1);

This bit will get cleared by a notifier callback.

In module_exit function of a related module:

         while (test_bit(PLL_LOCK_BIT, (unsigned long *)&boot_ratio)) {
                 msleep(1);
         }

This bit will get cleared by a timer. It will also fire the notifiers 
needed above.

I don't think these are in interrupt context. The sleeps ok here?

Also, from checkpatch:

ERROR: do not initialise externals to 0 or NULL
#2483: FILE: arch/powerpc/kernel/cpu/pll_if.c:486:
+int rval = 0;

ERROR: do not initialise statics to 0 or NULL
#2058: FILE: arch/powerpc/kernel/cpu/pll_if.c:61:
+static unsigned int override_bus_clock = 0;

Huh? What? Anyone care to teach an old dog a new trick???

kevin

next             reply	other threads:[~2008-08-13 12:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 12:01 Kevin Diggs [this message]
2008-08-13 13:00 ` details, details Arnd Bergmann
     [not found]   ` <48A33E6B.9010200@hypersurf.com>
     [not found]     ` <200808132305.45507.arnd@arndb.de>
2008-08-14  4:35       ` Kevin Diggs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A2CD2A.5020107@hypersurf.com \
    --to=kevdig@hypersurf$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox