Subject: Re: [PATCH v2] powerpc/boot: Delete unneeded .globl _zimage_start

From: Michael Ellerman <[email-masked]>
Date: Wed, 1 Apr 2020 23:53:31 +1100 (AEDT)

On Wed, 2020-03-25 at 16:42:57 UTC, Fangrui Song wrote:
> .globl sets the symbol binding to STB_GLOBAL while .weak sets the
> binding to STB_WEAK. GNU as let .weak override .globl since binutils-gdb
> 5ca547dc2399a0a5d9f20626d4bf5547c3ccfddd (1996). Clang integrated
> assembler let the last win but it may error in the future.
> 
> Since it is a convention that only one binding directive is used, just
> delete .globl.
> 
> Fixes: cd197ffcf10b "[POWERPC] zImage: Cleanup and improve zImage entry point"
> Fixes: ee9d21b3b358 "powerpc/boot: Ensure _zimage_start is a weak symbol"
> Link: https://github.com/ClangBuiltLinux/linux/issues/937
> Signed-off-by: Fangrui Song <[email-masked]>
> Cc: Alan Modra <[email-masked]>
> Cc: Joel Stanley <[email-masked]>
> Cc: Michael Ellerman <[email-masked]>
> Cc: Nick Desaulniers <[email-masked]>
> Cc: Segher Boessenkool <[email-masked]>
> Cc: [email-masked]

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/968339fad422a58312f67718691b717dac45c399

cheers