I regenerated the patch with respect to your comments. Grant Likely wrote: > On Thu, Oct 30, 2008 at 12:14 AM, René Bürgel wrote: > >> Hi! This patch adds the capability to the mpc52xx-uart to report framing >> errors, parity errors, breaks and overruns to userspace. These values may be >> requested in userspace by using the ioctl TIOCGICOUNT. >> >> Signed-off-by: René Bürgel >> > > Looks mostly good. A few comments below. Make sure you CC: me when > you send the next version (which goes for all 5xxx patches). > > g. > -- René Bürgel Software Engineer Unicontrol Systemtechnik GmbH OT Dittersbach Sachsenburger Weg 34 09669 Frankenberg Tel.: 03 72 06/ 88 73 - 19 Fax: 03 72 06/ 88 73 - 60 E-Mail: r.buergel@unicontrol.de Internet: www.unicontrol.de Unicontrol Systemtechnik GmbH Geschäftsführer: Dipl.-Ing. Siegfried Heinze Sitz der Gesellschaft: Frankenberg Registergericht: Amtsgericht Chemnitz, HRB 15 475