Subject: Re: [PATCH] ps3: ps3-lpm.c compile fix

From: Geoff Levand <[email-masked]>
Date: Mon, 3 Nov 2008 11:03:13 -0800

Alexey Dobriyan wrote:
> On Mon, Nov 03, 2008 at 09:20:28AM +0100, Geert Uytterhoeven wrote:
>> On Sun, 2 Nov 2008, Alexey Dobriyan wrote:
>> > drivers/ps3/ps3-lpm.c:838: error: implicit declaration of function 'get_hard_smp_processor_id'
>> > 
>> > Signed-off-by: Alexey Dobriyan <[email-masked]>

Acked-by: Geoff Levand <[email-masked]>

>> > --- a/drivers/ps3/ps3-lpm.c
>> > +++ b/drivers/ps3/ps3-lpm.c
>> > @@ -22,6 +22,7 @@
>> >  #include <linux/module.h>
>> >  #include <linux/interrupt.h>
>> >  #include <linux/uaccess.h>
>> > +#include <asm/smp.h>
>> 
>> #include <linux/smp.h>?
> 
> Nope, everybody else uses asm/smp.h.

That doesn't quite seem like enough reason for me.

Looking at the source, I see linux/smp.h only includes
asm/smp.h when CONFIG_SMP=y, so we at least need to
include asm/smp.h to get the get_hard_smp_processor_id
def when CONFIG_SMP=n.

-Geoff