From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: David Woodhouse <David.Woodhouse@intel•com>,
Arnd Bergmann <arnd@arndb•de>, Jim Paris <jim@jtan•com>,
linuxppc-dev@ozlabs•org,
Vivien Chappelier <vivien.chappelier@free•fr>,
cbe-oss-dev@ozlabs•org
Subject: [patch 3/6] mtd/ps3vram: Remove ps3vram debug routines
Date: Tue, 6 Jan 2009 13:32:15 -0800 [thread overview]
Message-ID: <4963CDDF.1040101@am.sony.com> (raw)
In-Reply-To: <4963CA52.9030902@am.sony.com>
Remove the ps3vram debug routines ps3vram_dump_ring() and
ps3vram_dump_reports(). These routines are not needed.
Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
---
drivers/mtd/devices/ps3vram.c | 29 -----------------------------
1 file changed, 29 deletions(-)
--- a/drivers/mtd/devices/ps3vram.c
+++ b/drivers/mtd/devices/ps3vram.c
@@ -87,9 +87,6 @@ struct ps3vram_priv {
#define DMA_NOTIFIER_HANDLE_BASE 0x66604200 /* first DMA notifier handle */
#define DMA_NOTIFIER_OFFSET_BASE 0x1000 /* first DMA notifier offset */
#define DMA_NOTIFIER_SIZE 0x40
-
-#define NUM_NOTIFIERS 16
-
#define NOTIFIER 7 /* notifier used for completion report */
/* A trailing '-' means to subtract off ps3fb_videomemory.size */
@@ -131,28 +128,6 @@ static int ps3vram_notifier_wait(struct
return -1;
}
-static void ps3vram_dump_ring(struct mtd_info *mtd)
-{
- struct ps3vram_priv *priv = mtd->priv;
- uint32_t *fifo;
-
- pr_info("PUT = %08x GET = %08x\n", priv->ctrl[CTRL_PUT],
- priv->ctrl[CTRL_GET]);
- for (fifo = priv->fifo_base; fifo < priv->fifo_ptr; fifo++)
- pr_info("%p: %08x\n", fifo, *fifo);
-}
-
-static void ps3vram_dump_reports(struct mtd_info *mtd)
-{
- struct ps3vram_priv *priv = mtd->priv;
- int i;
-
- for (i = 0; i < NUM_NOTIFIERS; i++) {
- uint32_t *n = ps3vram_get_notifier(priv->reports, i);
- pr_info("%p: %08x\n", n, *n);
- }
-}
-
static void ps3vram_init_ring(struct mtd_info *mtd)
{
struct ps3vram_priv *priv = mtd->priv;
@@ -284,8 +259,6 @@ static int ps3vram_upload(struct mtd_inf
ps3vram_fire_ring(mtd);
if (ps3vram_notifier_wait(mtd, 200) < 0) {
pr_err("notifier timeout\n");
- ps3vram_dump_ring(mtd);
- ps3vram_dump_reports(mtd);
return -1;
}
@@ -317,8 +290,6 @@ static int ps3vram_download(struct mtd_i
ps3vram_fire_ring(mtd);
if (ps3vram_notifier_wait(mtd, 200) < 0) {
pr_err("notifier timeout\n");
- ps3vram_dump_ring(mtd);
- ps3vram_dump_reports(mtd);
return -1;
}
--
next prev parent reply other threads:[~2009-01-06 21:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4963CA52.9030902@am.sony.com>
2009-01-06 21:32 ` [patch 2/6] powerpc/ps3: Add modalias support to the ps3vram driver Geoff Levand
2009-01-06 21:32 ` [patch 1/6] powerpc/ps3: ps3vram driver for accessing video RAM as MTD Geoff Levand
2009-01-06 21:32 ` Geoff Levand [this message]
2009-01-06 21:32 ` [patch 4/6] mtd/ps3vram: Cleanup ps3vram driver messages Geoff Levand
2009-01-06 21:32 ` [patch 5/6] mtd/ps3vram: Use kernel types Geoff Levand
2009-01-06 21:32 ` [patch 6/6] mtd/ps3vram: Use msleep in waits Geoff Levand
2009-01-07 19:25 ` Arnd Bergmann
2009-01-08 1:22 ` [patch 6/6 v2] " Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4963CDDF.1040101@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=David.Woodhouse@intel$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=jim@jtan$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=vivien.chappelier@free$(echo .)fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox