Subject: Re: [PATCH] fsldma: print correct IRQ on mpc83xx

From: Timur Tabi <[email-masked]>
Date: Wed, 14 Jan 2009 10:10:45 -0600

Peter Korsgaard wrote:

> @@ -875,7 +875,8 @@ static int __devinit fsl_dma_chan_probe(struct fsl_dma_device *fdev,
>  	}
>  
>  	dev_info(fdev->dev, "#%d (%s), irq %d\n", new_fsl_chan->id,
> -				compatible, new_fsl_chan->irq);
> +		 compatible,
> +		 new_fsl_chan->irq != NO_IRQ ? new_fsl_chan->irq : fdev->irq);

Wouldn't it be better to make sure that, on 83xx, new_fsl_chan->irq has the same
value as fdev->irq before we get here?

-- 
Timur Tabi
Linux kernel developer at Freescale