From: Andre Schwarz <andre.schwarz@matrix-vision•de>
To: Matt Sealey <matt@genesi-usa•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/5200: Bugfix for PCI mapping of memory and IMMR
Date: Fri, 30 Jan 2009 09:33:03 +0100 [thread overview]
Message-ID: <4982BB3F.3080509@matrix-vision.de> (raw)
In-Reply-To: <b5e2fc790901270956q4448ac4brd0f6ea177ace9ade@mail.gmail.com>
Matt Sealey wrote:
> On Mon, Jan 26, 2009 at 10:34 PM, Grant Likely
> <grant.likely@secretlab•ca> wrote:
>
>> From: Grant Likely <grant.likely@secretlab•ca>
>>
>> This patch ensures that memory gets properly mapped into the PCI
>> address space. Without this patch, the memory window BAR is left
>> at whatever value happened to be loaded into the BAR when Linux
>> was booted. Without this patch, memory could end up getting mapped
>> at any of the 1G address boundaries instead of at '0' where Linux
>> expects it.
>>
>> Similarly, this patch also ensures that the internally memory mapped
>> registers (IMMR) are mapped to the correct PCI address range.
>>
>> Without this patch, PCI appears to work correctly until a PCI
>> device is inserted which DMAs into memory.
>>
>> Signed-off-by: Grant Likely <grant.likely@secretlab•ca>
>> ---
>>
>> This is a bugfix that I intend to merge into 2.6.29 and once it is
>> mainlined get it added to the stable queue. If you have a 5200 system,
>> please test and make sure it works for you.
>>
>> Thanks
>> g.
>>
>> arch/powerpc/platforms/52xx/mpc52xx_pci.c | 24 ++++++++++--------------
>> 1 files changed, 10 insertions(+), 14 deletions(-)
>>
>>
>
> This doesn't affect Efika, right?
>
> What's the expected impact and how come nobody tried a DMA-capable PCI
> card in an MPC5200B board before? :)
>
>
We're running a MPC5200B based board with an external FPGA pumping as
much data into the CPU's memory as possible using scatter-gather DMA. No
problems so far ... besides the lousy PCI target performance of the
5200, of course. Of course we've been always running latest u-boot.
regards,
Andre
MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
next prev parent reply other threads:[~2009-01-30 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 4:34 [PATCH] powerpc/5200: Bugfix for PCI mapping of memory and IMMR Grant Likely
2009-01-27 17:56 ` Matt Sealey
2009-01-27 18:03 ` Grant Likely
2009-01-30 8:33 ` Andre Schwarz [this message]
2009-01-29 21:49 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4982BB3F.3080509@matrix-vision.de \
--to=andre.schwarz@matrix-vision$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=matt@genesi-usa$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox