From: Grzegorz Bernacki <gjb@semihalf•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v2] Add support for the digsy MTC board.
Date: Tue, 03 Feb 2009 09:56:47 +0100 [thread overview]
Message-ID: <498806CF.3030004@semihalf.com> (raw)
In-Reply-To: <fa686aa40902021126h26be6588t60956df5ecba5e77@mail.gmail.com>
Grant Likely wrote:
> Hey Grzegorz,
>
> I've pulled your patch into my -next tree, but I made a few changes first:
> - I dropped the defconfig changes because they conflict with the
> defconfig update that Ben just pulled from me
> - I updated the .dts file to reflect changes I was already making to
> all the other .dts files
> - I added the digsy-mtc board to the Kconfig documentation.
>
> I've pushed my whole queue of changes out to my -next tree. Please
> pull it down and try it out. (Note, this tree will get rebased at
> least once before I ask Ben to pull it, so be aware). Make sure that
> I haven't broken your .dts file. To get the defconfig change in, you
> can either send me another patch with just the defconfig change, or
> you can pop my version of your patch off the top of my -next tree and
> rebase your entire patch on top it. Whatever you prefer.
>
> One more note; the new digsy-mtc.dts file from my tree will probably
> not work with older kernels. Kernels need to be backward compatible
> with older .dts files, but the same is not true for the other way
> around.
>
> Here's my -next tree:
>
> git://git.secretlab.ca/git/linux-2.6-mpc52xx next
>
Hi Grant,
Thanks for pulling and updating my patch.
I got your tree and now I try to build kernel image for digsy, but I get
following errors:
arch/powerpc/platforms/52xx/mpc52xx_gpt.c:77: error: field 'of_gc' has incomplete type
arch/powerpc/platforms/52xx/mpc52xx_gpt.c: In function 'mpc52xx_gpt_gpio_setup':arch/powerpc/platforms/52xx/mpc52xx_gpt.c:350: error: parameter name omitted
arch/powerpc/platforms/52xx/mpc52xx_gpt.c:350: error: parameter name omitted
They disappear when I add support for OF gpio, but I think that parts of
mpc52xx_gpt.c file should be inside '#ifdef CONFIG_OF_GPIO' clause.
regards,
Grzesiek
next prev parent reply other threads:[~2009-02-03 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 16:01 [PATCH v2] Add support for the digsy MTC board Grzegorz Bernacki
2009-02-02 19:26 ` Grant Likely
2009-02-03 8:56 ` Grzegorz Bernacki [this message]
2009-02-03 21:02 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498806CF.3030004@semihalf.com \
--to=gjb@semihalf$(echo .)com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox