From: Geoff Levand <geoffrey.levand@am•sony.com>
To: James Bottomley <James.Bottomley@HansenPartnership•com>
Cc: linux-scsi <linux-scsi@vger•kernel.org>,
Mel Gorman <mel@csn•ul.ie>,
Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>,
linuxppc-dev@ozlabs•org, Jens Axboe <jens.axboe@oracle•com>
Subject: Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type
Date: Tue, 10 Feb 2009 14:46:19 -0800 [thread overview]
Message-ID: <499203BB.5010902@am.sony.com> (raw)
In-Reply-To: <1234151988.8776.4.camel@localhost.localdomain>
James Bottomley wrote:
> On Mon, 2009-02-09 at 11:11 +1100, Benjamin Herrenschmidt wrote:
>> The PS3 platform code wants to use some of the standard SCSI types from
>> there though, as they are part of the hypervisor ABI. (And in fact it
>> can be argued that non-block devices using SCSI do exist, such as
>> scanners, no ?)
>>
>> Any reason other than pre-historical to have blkdev.h shielded like
>> that ?
>
> Actually, I think the fix lies in scsi.h ... we can make that into a
> nicely independent protocol header file. Your current woes come because
> it pulls in scsi_cmnd.h ... perhaps just getting rid of this will fix
> it.
>
> Can the rest of linux-scsi verify that the fix below doesn't break
> something else?
>
> I found one cockup: block/cmd-filter.c is apparently not including
> linuc/blkdev.h directly but via scsi/scsi.h ... I fixed this up.
...
> diff --git a/block/cmd-filter.c b/block/cmd-filter.c
> diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
I tested this scsi header fix on PS3 and it fixes the BLK_MAX_CDB
not defined build error when CONFIG_BLOCK=n.
Acked-by: Geoff Levand <geoffrey.levand@am•sony.com>
next prev parent reply other threads:[~2009-02-10 22:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 16:58 2.6.29-rc3-git9 build break : arch/powerpc/platforms/ps3/setup.o Sachin P. Sant
2009-02-07 2:42 ` [patch] powerpc/ps3: Use hard coded values for LV1 device type Geoff Levand
2009-02-07 17:41 ` Sachin P. Sant
2009-02-08 11:29 ` Michael Ellerman
2009-02-09 0:11 ` Benjamin Herrenschmidt
2009-02-09 3:59 ` James Bottomley
2009-02-10 22:46 ` Geoff Levand [this message]
2009-02-11 5:28 ` Sachin P. Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499203BB.5010902@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=jens.axboe@oracle$(echo .)com \
--cc=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mel@csn$(echo .)ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox