From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Linuxppc-dev@ozlabs•org
Subject: [patch] powerpc/ps3: Move ps3_mm_add_memory to device_initcall
Date: Thu, 12 Feb 2009 14:36:16 -0800 [thread overview]
Message-ID: <4994A460.8000807@am.sony.com> (raw)
In-Reply-To: <49935F81.7060203@am.sony.com>
Change the PS3 hotplug memory routine ps3_mm_add_memory() from
a core_initcall to a device_initcall.
core_initcall routines run before the powerpc topology_init()
startup routine, which is a subsys_initcall, resulting in
failure of ps3_mm_add_memory() when CONFIG_NUMA=y. When
ps3_mm_add_memory() fails the system will boot with just the
128 MiB of boot memory
Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
---
Ben,
Please send upstream for 2.6.29, as this effects the current
Fedora 11 development kernel, and maybe other distros which
are based on 2.6.29.
arch/powerpc/platforms/ps3/mm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/powerpc/platforms/ps3/mm.c
+++ b/arch/powerpc/platforms/ps3/mm.c
@@ -328,7 +328,7 @@ static int __init ps3_mm_add_memory(void
return result;
}
-core_initcall(ps3_mm_add_memory);
+device_initcall(ps3_mm_add_memory);
/*============================================================================*/
/* dma routines */
prev parent reply other threads:[~2009-02-12 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 23:30 [RFC patch] powerpc: Add topology_ready to machdep calls Geoff Levand
2009-02-11 23:31 ` [RFC patch] powerpc/ps3: Add ps3_topology_ready routine Geoff Levand
2009-02-12 4:21 ` [RFC patch] powerpc: Add topology_ready to machdep calls Benjamin Herrenschmidt
2009-02-12 4:21 ` Benjamin Herrenschmidt
2009-02-12 22:36 ` Geoff Levand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4994A460.8000807@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox