Subject: Re: [PATCH v2] powerpc/83xx: Add power management support for MPC837x boards

From: Scott Wood <[email-masked]>
Date: Tue, 03 Mar 2009 12:39:38 -0600

Anton Vorontsov wrote:
> On Tue, Mar 03, 2009 at 11:57:46AM -0600, Scott Wood wrote:
>> On Tue, Mar 03, 2009 at 07:02:01PM +0300, Anton Vorontsov wrote:
>>>  		mdio@24520 {
>>> @@ -226,6 +244,8 @@
>>>  			interrupt-parent = <&ipic>;
>>>  			tbi-handle = <&tbi0>;
>>>  			phy-handle = <&phy2>;
>>> +			sleep = <&pmc 0xc0000000>;
>>> +			fsl,magic-packet;
>>>  		};
>> Note that this makes it look to the kernel like enet0 can be put to sleep
>> without putting the mdio (which is shared with enet1) to sleep.  This is
>> why I moved mdio under the ethernet node on 8313erdb.
> 
> And that isn't absolutely correct either, since enet1 depends on
> net0... If enet0's mdio goes into sleep mode before enet1, then
> enet1 will fail to send power-down command to its PHY...

But the kernel knows that enet1 depends on mdio0.  Getting the kernel to 
act on that knowledge isn't the device tree's problem.

-Scott