From: Mikhail Zolotaryov <lebon@lebon•org.ua>
To: linux-kernel@vger•kernel.org
Cc: linuxppc-dev@ozlabs•org
Subject: [PATCH] powerpc 4xx: DDR0_14[REDUC] decoded incorrectly
Date: Mon, 09 Mar 2009 18:21:36 +0200 [thread overview]
Message-ID: <49B54210.5040709@lebon.org.ua> (raw)
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
Hi,
according to the PPC440EPx Embedded Processor User Manual (rev 1.14)
DDR0_14[REDUC] bit has the following meaning:
REDUC - Enable the half data path feature of the controller
0 = Standard operation using full 64/72-bit memory bus
1 = Memory data path width is 32/40 bits
However, "1" is decoded as 64 bit (8 byte), "0" - as 32 bit (4 byte) bus
by the kernel code. My understanding is this is not correct - patch
attached.
[-- Attachment #2: patch-ibm4xx_denali_fixup_memsize.patch --]
[-- Type: text/plain, Size: 412 bytes --]
--- linux.orig/arch/powerpc/boot/4xx.c 2009-03-09 17:55:01.000000000 +0200
+++ linux/arch/powerpc/boot/4xx.c 2009-03-09 17:58:07.000000000 +0200
@@ -193,9 +193,9 @@
val = SDRAM0_READ(DDR0_14);
if (DDR_GET_VAL(val, DDR_REDUC, DDR_REDUC_SHIFT))
- dpath = 8; /* 64 bits */
- else
dpath = 4; /* 32 bits */
+ else
+ dpath = 8; /* 64 bits */
/* get address pins (rows) */
val = SDRAM0_READ(DDR0_42);
next reply other threads:[~2009-03-09 16:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 16:21 Mikhail Zolotaryov [this message]
2009-03-09 17:12 ` [PATCH] powerpc 4xx: DDR0_14[REDUC] decoded incorrectly Josh Boyer
2009-03-09 21:17 ` Mikhail Zolotaryov
2009-03-10 19:50 ` [PATCH] PowerPC 440EPx/GRx fix memory size calculation Valentine Barshak
2009-03-10 20:57 ` Mikhail Zolotaryov
2009-03-11 1:40 ` Valentine
2009-03-11 2:26 ` Benjamin Herrenschmidt
2009-03-11 8:24 ` Mikhail Zolotaryov
2009-03-11 8:29 ` Mikhail Zolotaryov
2009-03-11 10:37 ` Josh Boyer
2009-03-11 19:06 ` Valentine Barshak
2009-03-11 21:57 ` Josh Boyer
2009-03-11 22:08 ` Valentine
2009-03-11 23:07 ` Josh Boyer
2009-03-12 6:02 ` Stefan Roese
2009-03-12 7:32 ` Benjamin Herrenschmidt
2009-03-12 8:05 ` Stefan Roese
2009-03-12 8:12 ` Benjamin Herrenschmidt
2009-03-12 8:24 ` Stefan Roese
2009-03-12 8:45 ` Mikhail Zolotaryov
2009-03-12 10:45 ` Josh Boyer
2009-03-12 11:02 ` Stefan Roese
2009-03-13 23:01 ` Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B54210.5040709@lebon.org.ua \
--to=lebon@lebon$(echo .)org.ua \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox