From: Wolfgang Grandegger <wg@grandegger•com>
To: Wolfgang Grandegger <wg@grandegger•com>, linuxppc-dev@ozlabs•org
Subject: Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)
Date: Fri, 20 Mar 2009 23:02:32 +0100 [thread overview]
Message-ID: <49C41278.6060801@grandegger.com> (raw)
In-Reply-To: <20090320041022.GB30527@yookeroo.seuss>
David Gibson wrote:
> On Thu, Mar 19, 2009 at 04:26:44PM +0100, Wolfgang Grandegger wrote:
>> This patch adds support for the "socrates" board based on the MPC8544.
>> Supported are Ethernet, serial console, I2C, I2C-based RTC and
>> temperature sensors, NOR and NAND flash, PCI, USB, CAN and Lime
>> display controller.
>>
>> The multiplexing of FPGA interrupts onto PowerPC interrupt lines is
>> supported through our own fpga_pic interrupt controller driver.
>>
>> For example the SJA1000 controller is level low sensitive connected to
>> fpga_pic line 2 and is routed to the second (of three) irq lines to
>> the CPU:
>
> A few minor device tree nits.
>
>> + soc8544@e0000000 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + device_type = "soc";
>> +
>> + ranges = <0x00000000 0xe0000000 0x00100000>;
>> + reg = <0xe0000000 0x00001000>; // CCSRBAR 1M
>> + bus-frequency = <0>; // Filled in by U-Boot
>> + compatible = "fsl,socrates-immr", "simple-bus";
>
> This should probably refer to 8544 instead of socrates. Unless you
> really do have a board-specific version of the SoC...
OK, that should then be:
+ compatible = "fsl,mpc8544-immr", "simple-bus";
It should always be with the prefix "mpc", I guess. But some of the
following compatible names are without that prefix:
$ grep -h '\-l2-cache-controller' *
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,mpc8536-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8541-l2-cache-controller";
compatible = "fsl,8544-l2-cache-controller";
compatible = "fsl,8548-l2-cache-controller";
compatible = "fsl,8555-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8568-l2-cache-controller";
compatible = "fsl,mpc8572-l2-cache-controller";
compatible = "fsl,mpc8572-l2-cache-controller";
compatible = "fsl,mpc8572-l2-cache-controller";
compatible = "fsl,8548-l2-cache-controller";
compatible = "fsl,8560-l2-cache-controller";
compatible = "fsl,mpc8544-l2-cache-controller";
compatible = "fsl,mpc8544-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,mpc8548-l2-cache-controller";
compatible = "fsl,mpc8548-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
compatible = "fsl,8540-l2-cache-controller";
That's confusing.
Wolfgang.
next prev parent reply other threads:[~2009-03-20 22:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 15:26 powerpc/85xx: Add support for the "socrates" board (MPC8544) Wolfgang Grandegger
2009-03-20 4:10 ` David Gibson
2009-03-20 20:12 ` Wolfgang Grandegger
2009-03-20 22:02 ` Wolfgang Grandegger [this message]
2009-03-20 4:26 ` Kumar Gala
2009-03-20 20:16 ` Wolfgang Grandegger
2009-03-20 5:05 ` Grant Likely
2009-03-20 11:57 ` Wolfgang Grandegger
2009-03-31 9:35 ` Wolfgang Grandegger
2009-03-31 13:23 ` Grant Likely
2009-03-31 13:36 ` Wolfgang Grandegger
2009-03-31 15:05 ` Grant Likely
2009-03-31 15:54 ` Anton Vorontsov
2009-03-31 16:02 ` Grant Likely
2009-04-01 7:36 ` Wolfgang Grandegger
2009-04-01 12:40 ` Grant Likely
2009-04-01 13:10 ` Wolfgang Grandegger
2009-04-01 13:27 ` Kumar Gala
2009-04-01 13:49 ` Grant Likely
2009-04-02 6:38 ` Wolfgang Grandegger
2009-04-02 13:47 ` Kumar Gala
2009-04-02 18:50 ` Wolfgang Grandegger
2009-04-02 19:52 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C41278.6060801@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox