public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Wolfgang Grandegger <wg@grandegger•com>
To: linuxppc-dev <Linuxppc-dev@ozlabs•org>,
	devicetree-discuss <devicetree-discuss@ozlabs•org>
Subject: Inconsistent fsl_get_sys_freq() implementation
Date: Tue, 31 Mar 2009 09:28:36 +0200	[thread overview]
Message-ID: <49D1C624.2050502@grandegger.com> (raw)

Hello,

we realized an inconsistent implementation of fsl_get_sys_freq():

http://lxr.linux.no/linux+v2.6.29/arch/powerpc/sysdev/fsl_soc.c#L80

For 826x and 827x boards, the function is available but it cannot be
used because the "bus-frequency" property is not defined for the SOC and
U-Boot also does not try to do a fixup. I think that's a mistake, and
the DTS files and U-Boot should be fixed, right?
Furthermore, I find the name confusing. fsl_get_soc_bus_freq() would be
more appropriate also to distinguish from the frequencies of the CPU.
And why does the MPC52xx use a different name mpc52xx_find_ipb_freq()
for that frequency? It makes support for common hardware like I2C awkward.

Thanks.

Wolfgang.

next             reply	other threads:[~2009-03-31  7:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31  7:28 Wolfgang Grandegger [this message]
2009-03-31  7:33 ` Inconsistent fsl_get_sys_freq() implementation Grant Likely
2009-03-31  7:48   ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D1C624.2050502@grandegger.com \
    --to=wg@grandegger$(echo .)com \
    --cc=Linuxppc-dev@ozlabs$(echo .)org \
    --cc=devicetree-discuss@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox