public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger•com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs•org>,
	devicetree-discuss <devicetree-discuss@ozlabs•org>,
	linux-i2c@vger•kernel.org, Ben Dooks <ben-linux@fluff•org>
Subject: Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable
Date: Wed, 08 Apr 2009 21:55:48 +0200	[thread overview]
Message-ID: <49DD0144.7050902@grandegger.com> (raw)
In-Reply-To: <E9E24C93-F147-49F0-9FBE-FCE4883D11BF@kernel.crashing.org>

Kumar Gala wrote:
> 
> On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote:
> 
>>> So I'm a bit concerned with the output we now get:
>>>
>>> mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49)
>>>
>>> why 0? is that right?
>>
>> This is the backward compatibility mode using hard-coded FDR values. The
>> output is missleading, I agree.
>>
>> Wolfgang.
> 
> Can the output be fixed.  0 Hz seemed bad to me.

Of course. No info message will be printed for the legacy case
like it was with the old driver version. I just realized a bug in the
MPC52xx part. Will send patches tomorrow, after some more thorough testing.

Wolfgang.

  reply	other threads:[~2009-04-08 19:55 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07  8:20 [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
2009-04-07  8:20 ` [PATCH v3 1/5] i2c: i2c-mpc: various coding style fixes Wolfgang Grandegger
2009-04-07 15:36   ` Grant Likely
2009-04-07  8:20 ` [PATCH v3 2/5] i2c: i2c-mpc: use dev based printout function Wolfgang Grandegger
2009-04-07 15:37   ` Grant Likely
2009-04-07  8:20 ` [PATCH v3 3/5] i2c: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
2009-04-07 15:36   ` Grant Likely
2009-04-07  8:20 ` [PATCH v3 4/5] powerpc: i2c-mpc: document new FSL I2C bindings and cleanup Wolfgang Grandegger
2009-04-07 15:43   ` Grant Likely
2009-04-08  5:13   ` Kumar Gala
2009-04-07  8:20 ` [PATCH v3 5/5] powerpc/85xx: i2c-mpc: use new I2C bindings for the Socates board Wolfgang Grandegger
2009-04-07 15:43   ` Grant Likely
2009-04-08  7:16     ` Wolfgang Grandegger
2009-04-08 14:53       ` Grant Likely
2009-04-08 18:27         ` Wolfgang Grandegger
2009-04-08 18:43           ` Kumar Gala
2009-04-08 18:53             ` Wolfgang Grandegger
2009-04-08  5:11 ` [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable Kumar Gala
2009-04-08  5:16   ` Grant Likely
2009-04-08  5:22     ` Kumar Gala
2009-04-08  5:32       ` Grant Likely
2009-04-08  7:21       ` Wolfgang Grandegger
2009-04-08 17:03       ` Scott Wood
2009-04-08 17:49         ` Kumar Gala
2009-04-08  5:28   ` Kumar Gala
2009-04-08  7:25     ` Wolfgang Grandegger
2009-04-08 15:21       ` Kumar Gala
2009-04-08 19:55         ` Wolfgang Grandegger [this message]
2009-04-09  9:59           ` Wolfgang Grandegger
2009-04-20  9:01             ` Wolfgang Grandegger
2009-04-20 13:26               ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DD0144.7050902@grandegger.com \
    --to=wg@grandegger$(echo .)com \
    --cc=ben-linux@fluff$(echo .)org \
    --cc=devicetree-discuss@ozlabs$(echo .)org \
    --cc=galak@kernel$(echo .)crashing.org \
    --cc=linux-i2c@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox