From: Dave Jiang <djiang@mvista•com>
To: Jeff Haran <jharan@Brocade•COM>
Cc: linuxppc-dev@ozlabs•org,
Andrew Morton <akpm@linux-foundation•org>,
linux-kernel@vger•kernel.org,
Doug Thompson <dougthompson@xmission•com>
Subject: Re: bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check() ?
Date: Mon, 13 Apr 2009 10:10:36 -0700 [thread overview]
Message-ID: <49E3720C.8060008@mvista.com> (raw)
In-Reply-To: <20090410144715.0fa5939e.akpm@linux-foundation.org>
Jeff, you are correct. I will submit a patch to correct that.
Andrew Morton wrote:
> (cc's added)
>
> On Wed, 8 Apr 2009 14:57:42 -0700
> "Jeff Haran" <jharan@Brocade•COM> wrote:
>
>> Hi,
>>
>> Recent versions of this function start off with:
>>
>> static void mpc85xx_mc_check(struct mem_ctl_info *mci)
>> {
>> struct mpc85xx_mc_pdata *pdata = mci->pvt_info;
>> ...
>>
>> err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT);
>> if (err_detect)
>> return;
>>
>> ...
>> }
>>
>> My reading of the Freescale 8548E Manual leads me to conclude that the
>> Memory Error Detect register (ERR_DETECT) will have various bits set if
>> the memory controller has detected an error since the last time it was
>> cleared. If no memory error has occurred, the register will contain 0.
>>
>> Perhaps I am missing something very basic, but it seem to me that the
>> above "if" should be:
>>
>> if (!err_detect)
>> return;
>>
>> as the existing code would seem to read "if any errors have occurred,
>> ignore them", though perhaps testing has demonstrated that the Freescale
>> manual is in error.
>>
>> Please include this email address in responses as I do not subscribe.
>>
>> Thanks,
>>
>> Jeff Haran
>> Brocade
>
--
------------------------------------------------------
Dave Jiang
Software Engineer
MontaVista Software, Inc.
http://www.mvista.com
------------------------------------------------------
next prev parent reply other threads:[~2009-04-13 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <57AC2FA1761300418C7AB8F3EA493C9702C5F200@HQ-EXCH-5.corp.brocade.com>
2009-04-10 21:47 ` bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check() ? Andrew Morton
2009-04-13 17:10 ` Dave Jiang [this message]
[not found] <57AC2FA1761300418C7AB8F3EA493C9702E319DB@HQ-EXCH-5.corp.brocade.com>
2009-04-29 7:37 ` bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check() Andrew Morton
2009-04-29 12:46 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E3720C.8060008@mvista.com \
--to=djiang@mvista$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=dougthompson@xmission$(echo .)com \
--cc=jharan@Brocade$(echo .)COM \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox