From: Gary Thomas <gary@mlbassoc•com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: PCI changes 2.6.26 => 2.6.28
Date: Tue, 21 Apr 2009 17:45:04 -0600 [thread overview]
Message-ID: <49EE5A80.4030209@mlbassoc.com> (raw)
In-Reply-To: <306F293D-44CD-4238-ADA9-BB7436C7004C@kernel.crashing.org>
Kumar Gala wrote:
>
> On Apr 21, 2009, at 6:00 PM, Gary Thomas wrote:
>
>>
>> I found the difference - in 2.6.28 the inbound/outbound windows
>> don't seem to be set up at all. In 2.6.26, the function 'fsl_add_bridge'
>> was common among architectures and ended up calling 'setup_pci_atmu'
>> which created those mappings. In 2.6.28, the 83xx PCI setup code
>> has been refactored. It uses 'mpc83xx_add_bridge' instead of
>> 'fsl_add_bridge' and 'setup_pci_atmu' is not called at all :-(
>>
>> I'm sure this is the problem.
>
> Looking at a diff between 2.6.26 and .28 I don't see the 83xx pci code
> calling setup_pci_atmu().
It did not directly; it called 'fsl_add_bridge' which in turn called
'setup_pci_atmu'
I modified the 2.6.28 driver to also call this function. Now the
inbound/outbound windows are set up, but the bridge still has
no allocations, so the problem remains.
I need to move on; I may just live with sliding the PCI space
up for now (doesn't really hurt anything, just seems like a hack)
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
next prev parent reply other threads:[~2009-04-21 23:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 16:24 PCI changes 2.6.26 => 2.6.28 Gary Thomas
2009-04-21 20:30 ` Gary Thomas
2009-04-21 20:32 ` Gary Thomas
2009-04-21 20:33 ` Kumar Gala
2009-04-21 20:45 ` Gary Thomas
2009-04-21 22:22 ` Gary Thomas
2009-04-21 22:38 ` Kumar Gala
2009-04-21 22:50 ` Kumar Gala
2009-04-21 23:00 ` Gary Thomas
2009-04-21 23:41 ` Kumar Gala
2009-04-21 23:45 ` Gary Thomas [this message]
2009-04-22 3:51 ` Kumar Gala
2009-04-23 14:24 ` Gary Thomas
2009-04-23 18:47 ` Kumar Gala
2009-04-23 22:27 ` Gary Thomas
2009-04-27 13:17 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EE5A80.4030209@mlbassoc.com \
--to=gary@mlbassoc$(echo .)com \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox