From: Valentine Barshak <vbarshak@ru•mvista.com>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org, Stefan Roese <sr@denx•de>
Subject: Re: [PATCH] PPC440EPx SDRAM width
Date: Thu, 23 Apr 2009 19:16:06 +0400 [thread overview]
Message-ID: <49F08636.3080007@ru.mvista.com> (raw)
In-Reply-To: <20090423145915.GC3825@zod.rchland.ibm.com>
Josh Boyer wrote:
> On Thu, Apr 23, 2009 at 06:40:48PM +0400, Valentine Barshak wrote:
>> Stefan Roese wrote:
>>> On Thursday 23 April 2009, Josh Boyer wrote:
>>>> On Thu, Apr 23, 2009 at 09:36:12AM -0400, Steven A. Falco wrote:
>>>>> There is an error in the way ibm4xx_denali_fixup_memsize calculates
>>>>> memory size. When testing the DDR_REDUC bit, the polarity is
>>>>> backwards. A "1" implies 32-bit wide memory while a "0" implies
>>>>> 64-bit wide memory.
>>>>>
>>>>> For a 32-bit wide system, this bug causes twice the memory to be
>>>>> reported, leading to boot failure.
>>>>>
>>>>> Signed-off-by: Steven A. Falco <sfalco@harris•com>
>>>> So we had a previous patch for this, and a very long discussion on what the
>>>> right solution was. Either we never came to a resolution, or I have just
>>>> forgotten what it was.
>>>>
>>>> Stefan, Valentine, do either of you remember?
>> The patch will break sequia/rainier since u-boot doesn't set the number
>> of chipselects correctly for them. IIRC, the last conversation didn't
>> come to any conclusion. We sort of wanted to fix that regardless of
>> whether we had corrected u-boot or not.
>>
>> Could we use a "model" property to distinguish between the "real"
>> sequoia/rainier and other custom boards?
>> If yes, we could add a workaround the ibm4xx_denali_fixup_memsize to
>> hardcode the chipselect number to 1 for sequoia/rainier.
>
> We could do that perhaps, yes. In cases where the board has a newer U-Boot
> with the fix already, it shouldn't really cause any harm, correct?
Yes, that's correct.
Thanks,
Val
>
> josh
next prev parent reply other threads:[~2009-04-23 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 13:36 [PATCH] PPC440EPx SDRAM width Steven A. Falco
2009-04-23 13:45 ` Josh Boyer
2009-04-23 14:05 ` Stefan Roese
2009-04-23 14:40 ` Valentine Barshak
2009-04-23 14:59 ` Josh Boyer
2009-04-23 15:16 ` Valentine Barshak [this message]
2009-04-23 16:00 ` Steven A. Falco
2009-04-23 17:12 ` [PATCH] PowerPC: 440EPx/GRx Sequoia/Rainier U-Boot incorrect chipselect number workaround Valentine Barshak
2009-04-23 17:45 ` Steven A. Falco
2009-04-23 20:04 ` Valentine
2009-04-23 20:07 ` Josh Boyer
2009-04-23 20:12 ` Steven A. Falco
2009-04-23 20:55 ` [PATCH] PowerPC 44x: ibm4xx_denali_fixup_memsize fix Valentine Barshak
2009-04-24 4:23 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F08636.3080007@ru.mvista.com \
--to=vbarshak@ru$(echo .)mvista.com \
--cc=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sr@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox