Subject: Re: [PATCH 1/2] Added support for Designware SATA controller driver

From: Scott Wood <[email-masked]>
Date: Fri, 01 May 2009 16:26:10 -0500

Feng Kan wrote:
> This adds support for the Designware SATA controller.
> 
> Signed-off-by: Feng Kan <[email-masked]>
> Signed-off-by: Mark Miesfeld <[email-masked]>
> ---
>  drivers/ata/Kconfig    |   10 +
>  drivers/ata/Makefile   |    1 +
>  drivers/ata/sata_dwc.c | 2053 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 2064 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/ata/sata_dwc.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 0bcf264..c3d0b24 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -72,6 +72,16 @@ config SATA_FSL
>  
>  	  If unsure, say N.
>  
> +config SATA_DWC
> +	tristate "DesignWare Cores SATA support"
> + 	depends on 460EX

That "depends" looks too specific -- we don't want to grow a list if 
this controller gets added to other chips.

Only depend on what this driver actually needs in order to function.

-Scott