From: Timur Tabi <timur@freescale•com>
To: Jon Smirl <jonsmirl@gmail•com>
Cc: linuxppc-dev@ozlabs•org,
Geoff Thorpe <Geoff.Thorpe@freescale•com>,
smaclennan@pikatech•com
Subject: Re: [PATCH 1/2 v8] powerpc: introduce macro spin_event_timeout()
Date: Tue, 26 May 2009 13:01:10 -0500 [thread overview]
Message-ID: <4A1C2E66.7020902@freescale.com> (raw)
In-Reply-To: <9e4733910905261056v7a1a8e77ie6f273820ce1fd3e@mail.gmail.com>
Jon Smirl wrote:
> Then if I don't care about the result (which I think is the common case)...
>
> rc = spin_event_timeout(in_be32(x) & 0x14, ...);
> if (rc)
> timeout_happened;
That's another way of doing it, but I'm already at version 9 of my patch, and I'm not inclined to make any changes that don't add any real functionality. Every time I post a new version of this patch, someone new comes out of the woodwork to tell me that I should do it a different way. Where were you two months ago?
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-05-26 18:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 19:26 [PATCH 0/2] introduce macro spin_event_timeout() Timur Tabi
2009-05-19 19:26 ` [PATCH 1/2 v8] powerpc: " Timur Tabi
2009-05-19 19:26 ` [PATCH 2/2] qe: add polling timeout to qe_issue_cmd() Timur Tabi
2009-05-19 20:10 ` Grant Likely
2009-05-19 21:09 ` Timur Tabi
2009-05-25 17:46 ` [PATCH 1/2 v8] powerpc: introduce macro spin_event_timeout() Jon Smirl
2009-05-26 3:27 ` Timur Tabi
2009-05-26 16:20 ` Geoff Thorpe
2009-05-26 16:27 ` Jon Smirl
2009-05-26 17:03 ` Timur Tabi
2009-05-26 17:56 ` Jon Smirl
2009-05-26 18:01 ` Timur Tabi [this message]
2009-05-26 18:09 ` Geoff Thorpe
2009-05-26 18:17 ` Timur Tabi
2009-05-26 19:04 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1C2E66.7020902@freescale.com \
--to=timur@freescale$(echo .)com \
--cc=Geoff.Thorpe@freescale$(echo .)com \
--cc=jonsmirl@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=smaclennan@pikatech$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox