Subject: Re: [PATCH 31/33] ps3: Replace direct file operations by callback

From: Geoff Levand <[email-masked]>
Date: Wed, 10 Jun 2009 09:35:48 -0700

On 06/10/2009 07:39 AM, Geert Uytterhoeven wrote:
> Currently the FLASH database is updated by the kernel using file operations,
> meant for userspace only. While this works for us because copy_{from,to}_user()
> on powerpc can handle kernel pointers, this is unportable and a bad example.
> Replace the file operations by callbacks, registered by the ps3flash driver.

Thanks for getting this one done.

> Signed-off-by: Geert Uytterhoeven <[email-masked]>
> Cc: Geoff Levand <[email-masked]>
> ---
>  arch/powerpc/include/asm/ps3.h       |    7 ++
>  arch/powerpc/platforms/ps3/os-area.c |  138 ++++++++++++++++++---------------
>  drivers/char/ps3flash.c              |   94 +++++++++++++++++------
>  3 files changed, 152 insertions(+), 87 deletions(-)

Acked-by: Geoff Levand <[email-masked]>