From: Laszlo Fekete <blackluck@ktk•bme.hu>
To: michael@ellerman•id.au
Cc: Olof Johansson <olof@lixom•net>,
debian-powerpc@lists•debian.org,
Guennadi Liakhovetski <g.liakhovetski@gmx•de>,
linuxppc-dev@ozlabs•org
Subject: Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)
Date: Sat, 27 Jun 2009 19:46:29 +0200 [thread overview]
Message-ID: <4A465AF5.9000606@ktk.bme.hu> (raw)
In-Reply-To: <1245824392.9237.85.camel@concordia>
[-- Attachment #1.1: Type: text/plain, Size: 2032 bytes --]
Hello!
Thank you very much, this patch works me too.
Maybe this patch will be in the debian kernel someday?
Thank you: blackluck
Michael Ellerman wrote:
> On Wed, 2009-06-24 at 15:56 +1000, Benjamin Herrenschmidt wrote:
>
>> On Wed, 2009-06-24 at 15:53 +1000, Michael Ellerman wrote:
>>
>>> Doesn't fix my machine :/
>>>
>>>
>> That doesn't make sense ... What if you remove the bit inside the ifdef
>> CONFIG_MPIC_BROKEN_REGREAD in _mpic_read() ?
>>
>> If that makes a difference, then it would be interesting to add a printk
>> in there that prints what the original value "val" is and what we have
>> in the shadow...
>>
>
> With this patch it boots:
>
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index 2353adc..fc17289 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -231,13 +231,16 @@ static inline u32 _mpic_irq_read(struct mpic *mpic, unsign
> unsigned int isu = src_no >> mpic->isu_shift;
> unsigned int idx = src_no & mpic->isu_mask;
> unsigned int val;
> + unsigned int shadow;
>
> val = _mpic_read(mpic->reg_type, &mpic->isus[isu],
> reg + (idx * MPIC_INFO(IRQ_STRIDE)));
> #ifdef CONFIG_MPIC_BROKEN_REGREAD
> - if (reg == 0)
> - val = (val & (MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY)) |
> + if (reg == 0) {
> + shadow = (val & (MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY)) |
> mpic->isu_reg0_shadow[idx];
> + printk("%s: val 0x%x shadow 0x%x\n", __func__, val, shadow);
> + }
> #endif
> return val;
> }
>
>
> And I see:
>
> sym53c8xx 0000:00:0c.0: enabling device (0140 -> 0143)
> sym0: <896> rev 0x7 at pci 0000:00:0c.0 irq 17
> sym0: No NVRAM, ID 7, Fast-40, SE, parity checking
> _mpic_irq_read: val 0x80480004 shadow 0x80080014
> _mpic_irq_read: val 0x480004 shadow 0x480004
>
>
>
> cheers
>
[-- Attachment #1.2: Type: text/html, Size: 2541 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2009-06-27 17:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 9:10 sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd) Guennadi Liakhovetski
2009-06-17 9:33 ` Laszlo Fekete
2009-06-22 9:10 ` Laszlo Fekete
2009-06-23 1:18 ` Benjamin Herrenschmidt
2009-06-23 2:30 ` Benjamin Herrenschmidt
2009-06-23 21:57 ` Benjamin Herrenschmidt
2009-06-23 23:29 ` Benjamin Herrenschmidt
2009-06-24 5:53 ` Michael Ellerman
2009-06-24 5:56 ` Benjamin Herrenschmidt
2009-06-24 6:19 ` Michael Ellerman
2009-06-24 9:31 ` Benjamin Herrenschmidt
2009-06-27 17:46 ` Laszlo Fekete [this message]
2009-06-27 22:54 ` Benjamin Herrenschmidt
2009-07-06 9:05 ` Michael Ellerman
2009-06-23 2:31 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A465AF5.9000606@ktk.bme.hu \
--to=blackluck@ktk$(echo .)bme.hu \
--cc=debian-powerpc@lists$(echo .)debian.org \
--cc=g.liakhovetski@gmx$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
--cc=olof@lixom$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox