Subject: Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

From: Timur Tabi <[email-masked]>
Date: Wed, 01 Jul 2009 16:13:43 -0500

Anton Vorontsov wrote:

> diff --git a/arch/powerpc/sysdev/qe_lib/qe_ic.c b/arch/powerpc/sysdev/qe_lib/qe_ic.c
> index 63cdf98..074905c 100644
> --- a/arch/powerpc/sysdev/qe_lib/qe_ic.c
> +++ b/arch/powerpc/sysdev/qe_lib/qe_ic.c
> @@ -333,12 +333,10 @@ void __init qe_ic_init(struct device_node *node, unsigned int flags,
>  	if (ret)
>  		return;
>  
> -	qe_ic = alloc_bootmem(sizeof(struct qe_ic));
> +	qe_ic = kzalloc(sizeof(*qe_ic), GFP_KERNEL);

This function is called during init_IRQ() in main.c.  Looking at the code, I don't see any earlier calls to kzalloc().  Are you sure this is supposed to work?

-- 
Timur Tabi
Linux kernel developer at Freescale